Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_root_pool: always create ESP #35

Merged
merged 2 commits into from Mar 7, 2018
Merged

Conversation

@tsoome
Copy link

tsoome commented Feb 9, 2018

No description provided.

@tsoome tsoome force-pushed the tsoome:loader branch from 7f010f2 to 4240a89 Feb 9, 2018
@tsoome tsoome force-pushed the tsoome:loader branch 2 times, most recently from a4fb465 to 6117943 Mar 6, 2018
@pyhalov
Copy link

pyhalov commented Mar 6, 2018

<leoric> tsoome: on boot I get warning about zfs unable to find rpool1 (installing over already installed system). Also zpool sees 256MB as expandsz, which looks strange
<leoric> (can't read MOS of pool rpool1)
<leoric> did zpool create -B preserve some old labels?
<leoric> should we do something like zpool labelclear disk || true for every disk?
<leoric> or should loader be more clever about zfs labels? 
<leoric> reinstalling over this system doesn't help
@tsoome tsoome force-pushed the tsoome:loader branch from 6117943 to 6ec6627 Mar 7, 2018
@tsoome
Copy link
Author

tsoome commented Mar 7, 2018

Yes, we need to use labelclear on ESP to make sure we do not have any leftovers there.

@tsoome tsoome force-pushed the tsoome:loader branch from 6ec6627 to 2bcb83e Mar 7, 2018
@pyhalov pyhalov changed the title typo in create_root_pool create_root_pool: always create ESP Mar 7, 2018
@pyhalov pyhalov merged commit 0a9202b into OpenIndiana:oi/hipster Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.