fix: EnvironmentActions validation edge case #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



The EnvironmentActions oneOf validator assumed that actions was a dictionary.
If the template being validated had an environment action of any other type then an AttributeError would throw
Fixes:
What was the problem/requirement? (What/Why)
If the template being validated had an environment action of any type other than a dict then an AttributeError would throw
What was the solution? (How)
The requires_oneof first ensures that the action is a Dict before continuing
What is the impact of this change?
openjd check will no longer crash when presented with a template with this sort of error
How was this change tested?
A new unit test was added
See DEVELOPMENT.md for information on running tests.
yes
Was this change documented?
no
no, not sure there are any.
Is this a breaking change?
no
A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Interfaces section
of the DEVELOPMENT.md for more information on the public contracts.
If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.
Does this change impact security?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.