Remove generated freenect.c from python binding #326

Closed
florianletsch opened this Issue Apr 25, 2013 · 0 comments

2 participants

@florianletsch

I tried to get the unstable lib with python bindings running on my Mac OS. Building the lib from the unstable branch was easy using homebrew and brew edit libfreenect to fetch the HEAD from unstable.

However, when trying to build and install the python binding I ran into problems. After a lot of looking into the code I realized that wrappers/python/freenect.c seems to be out of with from wrappers/python/freenect.pyx. For example I noticed DEPTH_REGISTERED missing.

Maybe you could remove the freenect.c from the source, so that people build it themselves using Cython. Or you take care of always keeping it in sync with the .pyx
Up to you, it would just be nice to not have other people run into the same problem over and over again.

Or do I just misunderstand the way the code is structured?

@piedar piedar modified the milestone: v0.5.0, v0.4.2 Mar 23, 2014
@piedar piedar modified the milestone: v0.4.3, v0.4.2 Apr 29, 2014
@piedar piedar added a commit that closed this issue May 2, 2014
@piedar piedar wrappers/python: update freenect.c - fixes #326
Signed-off-by: Benn Snyder <benn.snyder@gmail.com>
d9cc2b2
@piedar piedar closed this in d9cc2b2 May 2, 2014
@yarikoptic yarikoptic added a commit to yarikoptic/libfreenect that referenced this issue Feb 14, 2015
@yarikoptic yarikoptic Merge tag 'v0.5.0' into dfsg
libfreenect v0.5.0 Satellite

* tag 'v0.5.0': (44 commits)
  Fix stupid comparison mistake in audio serial fallback
  Update CMakeList.txt and ebuild for v0.5.0
  c_sync: Collapse unused functions
  Configure audio support at runtime - fixes #372
  Use audio serial as a fallback for K4W and 1473 models that do not provide a useful camera serial (thanks @olzhas). Fixes #360 and resolves #393.
  Remove legacy keep_alive.c; now require libusb >= 1.0.18
  c_sync: Add freenect_sync_camera_to_world() (thanks @martyvona) - fixes #294
  Fix a crash-on-exit in the OpenNI2 driver caused by using a deleted iterator.
  Cleanup imports in examples; also fixes a micview compile error on OS X.
  Allow freenect_set_tilt_degs to take a negative angle
  Update CMakeLists.txt for v0.4.3
  win32: Fix command in examples/CMakeLists.txt
  ebuild: Improve python dependency - fixes #391
  Standardize indentation in fnusb_open_subdevices
  Use non-infinite timeouts for bulk tilt / led commands Reset the audio device before using it to ensure the commands can be sent correctly Fixes #390
  Update README.md and CMakeLists.txt for v0.4.2
  Fix fakenect not handling freenect_process_events_timeout
  FN_DEBUG: print read_register and read_cmos_register replies
  Fix cmake module include order Fix cpack user option on linux Separate cpack options for different generators and add tgz generator Add cmake config file Fixes #355
  wrappers/python: update freenect.c - fixes #326
  ...
9716fbf
@yarikoptic yarikoptic added a commit to yarikoptic/libfreenect that referenced this issue Feb 14, 2015
@yarikoptic yarikoptic Merge branch 'dfsg' into debian
* dfsg: (84 commits)
  Fix stupid comparison mistake in audio serial fallback
  Update CMakeList.txt and ebuild for v0.5.0
  c_sync: Collapse unused functions
  Configure audio support at runtime - fixes #372
  Use audio serial as a fallback for K4W and 1473 models that do not provide a useful camera serial (thanks @olzhas). Fixes #360 and resolves #393.
  Remove legacy keep_alive.c; now require libusb >= 1.0.18
  c_sync: Add freenect_sync_camera_to_world() (thanks @martyvona) - fixes #294
  Fix a crash-on-exit in the OpenNI2 driver caused by using a deleted iterator.
  Cleanup imports in examples; also fixes a micview compile error on OS X.
  Allow freenect_set_tilt_degs to take a negative angle
  Update CMakeLists.txt for v0.4.3
  win32: Fix command in examples/CMakeLists.txt
  ebuild: Improve python dependency - fixes #391
  Standardize indentation in fnusb_open_subdevices
  Use non-infinite timeouts for bulk tilt / led commands Reset the audio device before using it to ensure the commands can be sent correctly Fixes #390
  Update README.md and CMakeLists.txt for v0.4.2
  Fix fakenect not handling freenect_process_events_timeout
  FN_DEBUG: print read_register and read_cmos_register replies
  Fix cmake module include order Fix cpack user option on linux Separate cpack options for different generators and add tgz generator Add cmake config file Fixes #355
  wrappers/python: update freenect.c - fixes #326
  ...
b8649d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment