From f700e92f4b2783a1756de61c7ec88ce9a4184e2d Mon Sep 17 00:00:00 2001 From: Val Alexander Date: Fri, 27 Mar 2026 13:55:02 -0500 Subject: [PATCH] Default new diff files to collapsed - Make unrevealed diff files start collapsed in the review state - Update the DiffPanel fallback and tests to match the new default --- apps/web/src/components/DiffPanel.tsx | 2 +- apps/web/src/lib/diffFileReviewState.test.ts | 5 +++-- apps/web/src/lib/diffFileReviewState.ts | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/apps/web/src/components/DiffPanel.tsx b/apps/web/src/components/DiffPanel.tsx index 3d2dbc215..99f7b3d14 100644 --- a/apps/web/src/components/DiffPanel.tsx +++ b/apps/web/src/components/DiffPanel.tsx @@ -679,7 +679,7 @@ export default function DiffPanel({ mode = "inline" }: DiffPanelProps) { const themedFileKey = `${fileKey}:${resolvedTheme}`; const fileReviewState = activeReviewState[filePath] ?? { accepted: false, - collapsed: false, + collapsed: true, }; return ( { }); }); - it("initializes new files as unaccepted and expanded", () => { + it("initializes new files as unaccepted and collapsed", () => { expect(reconcileDiffFileReviewState(["src/a.ts"], undefined)).toEqual({ - "src/a.ts": { accepted: false, collapsed: false }, + "src/a.ts": { accepted: false, collapsed: true }, }); }); }); @@ -79,6 +79,7 @@ describe("expandDiffFile", () => { const state = { "src/a.ts": { accepted: false, collapsed: false }, }; + // File is already expanded, so the same object reference is returned. expect(expandDiffFile(state, "src/a.ts")).toBe(state); }); }); diff --git a/apps/web/src/lib/diffFileReviewState.ts b/apps/web/src/lib/diffFileReviewState.ts index 3b6c89838..e82fc2c94 100644 --- a/apps/web/src/lib/diffFileReviewState.ts +++ b/apps/web/src/lib/diffFileReviewState.ts @@ -6,7 +6,7 @@ export interface DiffFileReviewState { export type DiffFileReviewStateByPath = Record; const DEFAULT_DIFF_FILE_REVIEW_STATE: DiffFileReviewState = { - collapsed: false, + collapsed: true, accepted: false, };