Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add very limited support for random options in item names #200

Merged
merged 3 commits into from Dec 21, 2016
Merged

Conversation

allanon
Copy link
Member

@allanon allanon commented Aug 19, 2016

  • QA Review
  • Code Review (this code is at best incomplete - only the options which are currently implemented in iRO are expected to work)

This shows the new Crimson weapons with "Fire", "Ice", etc in the name.

I've also added a data file which was extracted from data\luafiles514\lua files\datainfo\addrandomoptionnametable.lub. (Speaking of which, does anybody have an easy way to decompile a lub? luadec gave me header errors.)

@cydh
Copy link
Contributor

@cydh cydh commented Nov 17, 2016

@allanon for luadec, use the luadec5.1.4.exe

and the question for crimson weapon on iRO, the element given since the item is dropped or while identifying?
I meant, by using this update, at least if you got the crimson weapon u can look into the item list it has randomoption or not yet.
Thank you

@allanon
Copy link
Member Author

@allanon allanon commented Nov 17, 2016

I'll have to see if luadec5.1.4 has a Linux version, since I don't use Windows.

The options are in the item packet even before the item is identified, so yes, decisions could be made on whether to pick up (or drop, sell, store, etc) the item without having to identify it first.

@deado
Copy link

@deado deado commented Dec 19, 2016

Started testing this pull on iRO for Crimson weapon Elements support. This pull request was made before the recent addition/changes of packets 09DB, 09DC, 09DD, etc. so those are showing up Unknown Switch... However, it seems to read all the elements nicely (at least all the ones I currently have in a cart). Works if the item is identified or not. IMO these changes for the crimson element support could be merged with the main repo

@allanon allanon merged commit 52856dc into master Dec 21, 2016
@allanon allanon deleted the random_options branch Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants