New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable substitution in deployment descriptors and annotations #3963

Open
NottyCode opened this Issue Jun 13, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@NottyCode
Member

NottyCode commented Jun 13, 2018

Glassfish and payara allow for variables to be specified in deployment descriptors and annotation equivilents. This is documented here

This is non-portable if used, but it does mean that you can override the configuration at deployment time. In Liberty this is done by doing an override of the deployment descriptor in server.xml, but allowing variable substitution would be an alternative that might be simpler, especially in fat jar or docker deployment scenarios.

@NottyCode

This comment has been minimized.

Member

NottyCode commented Jun 26, 2018

On a call this was discussed and it was agreed this seemed like a good idea with the following observations:

  • We should look at how we can optionally integrate this with MP config. This shouldn't be a hard requirement, but an optional one.
  • We should look at providing default values for the variable substitution
  • We should ensure that if we can't resolve a variable something sensible happens at app startup time.
  • We need to look at dynamic configuration to ensure that variable changing works correctly. Ideally it wouldn't force an app restart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment