Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EJB Custom Bindings add translated files and server ejbcontainer config properties #8665

Merged

Conversation

@olendvcook
Copy link
Member

commented Aug 19, 2019

I decided to go with the behavior that the config elements will overwrite whatever is in the JVM properties if the config elements have something in them, otherwise it will take what's in the JVM props, or lastly the defaults set by the JVM props.

One exception is disableShortDefaultBindings, this is a list of apps, I decided to merge the 2 lists if they both exist, duplicates don't matter.

@LibbyBot LibbyBot added the CLA Signed label Aug 19, 2019

@LibbyBot

This comment has been minimized.

Copy link

commented Aug 19, 2019

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 6 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.ejbcontainer.core/resources/com/ibm/ejs/container/container.nlsprops

  • 2 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.ejbcontainer/resources/OSGI-INF/l10n/metatype.properties

  • dev/com.ibm.ws.ejbcontainer.core/resources/com/ibm/ejs/container/container.nlsprops

@olendvcook olendvcook requested review from tkburroughs and brideck Aug 19, 2019

@olendvcook

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

#build

@LibbyBot

This comment has been minimized.

Copy link

commented Aug 20, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OOI3oMNFEemqwb6GhJpP2g

Target locations of links might be accessible only to IBM employees.

@skasund skasund added the L2 Reviewed label Aug 20, 2019

@LibbyBot

This comment has been minimized.

@skasund

This comment has been minimized.

Copy link

commented Aug 20, 2019

L2 message review completed

@LibbyBot

This comment has been minimized.

Copy link

commented Aug 20, 2019

@olendvcook olendvcook force-pushed the olendvcook:EJBCustomBindingsMetatype branch from 0a27577 to 8457964 Aug 26, 2019

@olendvcook

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

#build

@LibbyBot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_U6JZoMhIEemXQfpXthgueA

Target locations of links might be accessible only to IBM employees.

@LibbyBot

This comment has been minimized.

@LibbyBot

This comment has been minimized.

Copy link

commented Aug 27, 2019

@olendvcook olendvcook merged commit d6b3fb1 into OpenLiberty:integration Aug 27, 2019

1 check passed

RTC build The build completed and passed successfully!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.