Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Save port patchings immediately rather than on shutdown #125
From nomis52 on October 21, 2010 08:05:49
If we only save on shutdown, the patchings aren't saved correctly if olad crashes which is annoying during development.
This needs to be done asynchronously though so we don't block dmx processing while waiting on disk writes.
Original issue: http://code.google.com/p/open-lighting/issues/detail?id=124
referenced this issue
Jan 11, 2016
Any news on this enhancement ?
I realize that it would be beneficial that the save procedure happens in a separate thread in order to not impact dmx, but as a quick hack in the meanwhile couldn't we use a cmd line switch to enable this feature (explicitly explaining it's possible causes) and save it anyway in OladHTTPServer::CreateNewUniverse ?
and on OladHTTPServer::CreateNewUniverse
Hi @rbarreiros it's been on our GSoC list in the past, but never been picked by anyone.
It'd probably be a question for @nomis52 if something "hacky" like that makes it in, but given the relevant triviality, you could always create a PR and see. Likewise we'd value any help in adding the separate thread to do it in. The best solution for the hack may be to only expose the option if a configure flag is added, like the root stuff: