New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save port patchings immediately rather than on shutdown #125

Open
ola-importer opened this Issue Dec 24, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@ola-importer

ola-importer commented Dec 24, 2013

From nomis52 on October 21, 2010 08:05:49

If we only save on shutdown, the patchings aren't saved correctly if olad crashes which is annoying during development.

This needs to be done asynchronously though so we don't block dmx processing while waiting on disk writes.

Original issue: http://code.google.com/p/open-lighting/issues/detail?id=124

@ola-importer

This comment has been minimized.

Show comment
Hide comment
@ola-importer

ola-importer Dec 24, 2013

From nomis52 on October 23, 2010 20:53:42

Issue 125 has been merged into this issue.

ola-importer commented Dec 24, 2013

From nomis52 on October 23, 2010 20:53:42

Issue 125 has been merged into this issue.

@ola-importer

This comment has been minimized.

Show comment
Hide comment
@ola-importer

ola-importer Dec 24, 2013

From si...@nomis52.net on August 29, 2011 09:25:47

Labels: Milestone-Release0.8.13

ola-importer commented Dec 24, 2013

From si...@nomis52.net on August 29, 2011 09:25:47

Labels: Milestone-Release0.8.13

@ola-importer

This comment has been minimized.

Show comment
Hide comment
@ola-importer

ola-importer Dec 24, 2013

From si...@nomis52.net on October 21, 2011 08:29:33

Labels: -Milestone-Release0.8.13 Milestone-Release0.8.14

ola-importer commented Dec 24, 2013

From si...@nomis52.net on October 21, 2011 08:29:33

Labels: -Milestone-Release0.8.13 Milestone-Release0.8.14

@ola-importer

This comment has been minimized.

Show comment
Hide comment
@ola-importer

ola-importer Dec 24, 2013

From si...@nomis52.net on March 06, 2012 06:19:23

Labels: -Milestone-Release0.8.14

ola-importer commented Dec 24, 2013

From si...@nomis52.net on March 06, 2012 06:19:23

Labels: -Milestone-Release0.8.14

@rbarreiros

This comment has been minimized.

Show comment
Hide comment
@rbarreiros

rbarreiros Mar 24, 2017

Contributor

Any news on this enhancement ?
I have been using OLA with nard, which is something meant to be used as a device that doesn't require shutdowns, and it's a problem when the universe patches aren't saved when when created.

I realize that it would be beneficial that the save procedure happens in a separate thread in order to not impact dmx, but as a quick hack in the meanwhile couldn't we use a cmd line switch to enable this feature (explicitly explaining it's possible causes) and save it anyway in OladHTTPServer::CreateNewUniverse ?

Something like:

--save-on-demand
Saves settings immediately after configuration changes through the UI but may cause DMX flicker

and on OladHTTPServer::CreateNewUniverse

...
if(save_on_demand_flag) {
  m_server->savePreferences();
  m_server->saveUniversePreferences();
}
...

Contributor

rbarreiros commented Mar 24, 2017

Any news on this enhancement ?
I have been using OLA with nard, which is something meant to be used as a device that doesn't require shutdowns, and it's a problem when the universe patches aren't saved when when created.

I realize that it would be beneficial that the save procedure happens in a separate thread in order to not impact dmx, but as a quick hack in the meanwhile couldn't we use a cmd line switch to enable this feature (explicitly explaining it's possible causes) and save it anyway in OladHTTPServer::CreateNewUniverse ?

Something like:

--save-on-demand
Saves settings immediately after configuration changes through the UI but may cause DMX flicker

and on OladHTTPServer::CreateNewUniverse

...
if(save_on_demand_flag) {
  m_server->savePreferences();
  m_server->saveUniversePreferences();
}
...

@peternewman

This comment has been minimized.

Show comment
Hide comment
@peternewman

peternewman Apr 12, 2017

Member

Hi @rbarreiros it's been on our GSoC list in the past, but never been picked by anyone.

It'd probably be a question for @nomis52 if something "hacky" like that makes it in, but given the relevant triviality, you could always create a PR and see. Likewise we'd value any help in adding the separate thread to do it in. The best solution for the hack may be to only expose the option if a configure flag is added, like the root stuff:
https://github.com/OpenLightingProject/ola/blob/master/configure.ac#L683

Member

peternewman commented Apr 12, 2017

Hi @rbarreiros it's been on our GSoC list in the past, but never been picked by anyone.

It'd probably be a question for @nomis52 if something "hacky" like that makes it in, but given the relevant triviality, you could always create a PR and see. Likewise we'd value any help in adding the separate thread to do it in. The best solution for the hack may be to only expose the option if a configure flag is added, like the root stuff:
https://github.com/OpenLightingProject/ola/blob/master/configure.ac#L683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment