Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
added APA102 with Pixel Brightness mode #1358
A few comments, mostly fairly minor.
It would be nice to have a CombinedAPA102ControlPixelBrightness personality for completeness, i.e. 4 channels controlling a whole strip.
If possible in your hardware tests, if possible it would be good to check two blocks, one in PB mode, one not, work when driven from the same plugin.
thanks @peternewman for your comments - i found today that i did forget to include the test.... ;-)
Which one uses && for bitwise AND then, as opposed to logical, or does it use the same for both?
The test isn't passing, because as per one of my other comments, you're using the wrong personality, so you're not generating data via your code, but trying to test to match it.
Mostly just style issues now thanks s-light.
Just a couple more minor style changes please.
real-world-test done :-)
Just a few more minor comments.
Can we get the style and comment removal stuff done. The slot data changes could wait until a future PR or someone else if you'd rather.