From f69eee564afd07163732020dd56ac2ca5cc485e5 Mon Sep 17 00:00:00 2001 From: Ken Harris Date: Mon, 30 Oct 2023 20:38:38 -0700 Subject: [PATCH] Add protobuf syntax version The protocol buffer spec suggests that this is required. I've tried two protobuf libraries, and one errors without this, and the other prints a warning. There's no documentation in OLA I can find that it's proto2, but it works this way, and it makes sense. Both files use "required", which was removed from proto3. --- common/protocol/Ola.proto | 2 ++ common/rpc/Rpc.proto | 2 ++ 2 files changed, 4 insertions(+) diff --git a/common/protocol/Ola.proto b/common/protocol/Ola.proto index 02896effa4..c9a97be1ff 100644 --- a/common/protocol/Ola.proto +++ b/common/protocol/Ola.proto @@ -18,6 +18,8 @@ * Copyright (C) 2005 Simon Newton */ +syntax = "proto2"; + package ola.proto; option cc_generic_services = false; diff --git a/common/rpc/Rpc.proto b/common/rpc/Rpc.proto index 27eb002b28..9f9ec20dbb 100644 --- a/common/rpc/Rpc.proto +++ b/common/rpc/Rpc.proto @@ -18,6 +18,8 @@ * Copyright (C) 2005 Simon Newton */ +syntax = "proto2"; + /* * Based on, but not guaranteed to be the same as the specification here: * http://protorpc.likbilen.com/Protorpcdocprotobuf.html