Refactor everything to ES Modules #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
force-pushed
the
esm
branch
2 times, most recently
from
9f353cd
to
50c9a0f
Compare
This comment has been minimized.
This comment has been minimized.
FloEdelmann
force-pushed
the
esm
branch
2 times, most recently
from
5f159fb
to
fe0dc6a
Compare
FloEdelmann
force-pushed
the
esm
branch
2 times, most recently
from
aae6564
to
59e5649
Compare
FloEdelmann
force-pushed
the
esm
branch
2 times, most recently
from
82bc53d
to
a78fbd4
Compare
but don't drop the dependency yet to not break the export-diff test
to ensures the correct decodings of percent-encoded characters and cross-platform valid absolute path string
This comment has been minimized.
This comment has been minimized.
FloEdelmann
added a commit
that referenced
this pull request
May 13, 2021
This reverts commit a1a55e0.
This was referenced May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECMAScript Modules (ESM) support first appeared without a command-line flag in Node.js v14: https://nodejs.org/docs/latest-v14.x/api/esm.html
In Node,
importdoes not work with.jsonfiles (without another command-line flag), that's why in #1623 I replaced them and in #1625 implemented a workaround.To do in this PR
color-name-list's.esm.mjsfile directlyunicorn/import-indexrule, because of sindresorhus/eslint-plugin-unicorn@ff1cd2eunicorn/prefer-moduleruleembetty-vuea pure ESM dependencyTo do after this is merged
esmdependency frompackage.jsonimport/no-duplicatesruleimport/orderruleimport/newline-after-importruleimport/firstruleimport/exports-lastruleunicorn/import-styleconfiguration withno-restricted-importsunicorn/prefer-node-protocolrule once Supportnode:protocol unjs/jiti#30 is fixed