New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Google Blogger ClientLogin to OAuth 2.0 #5

Closed
dariuszparys opened this Issue Dec 9, 2015 · 24 comments

Comments

Projects
None yet
@dariuszparys
Member

dariuszparys commented Dec 9, 2015

Google Blogger deprecated ClientLogin in 2012 but Open Live Writer is still using it. We should update to OAuth 2.0. Google provides a .NET library for OAuth 2.0 at https://github.com/google/google-api-dotnet-client.

Following is a brief history of the current work on this issue.

We identified the code where the login process and the BloggerAtomClient, but for doing this we need to modify the UI of the wizard and create a new step where we prompt the user to click on authorization process and then get the OAuth token from Google Server.

There are some open questions:

  • Where do we store the token, as the password of the user on the CredentialStorage?
  • When and how to handle OAuth invalidations, for example when the user is going to publish but he handle is invalid, ect.
  • We need to create a Application inside Google Developer Console, I can create now using my personal google account but, of couse, in the future we need to use Microsoft´s account for creating this app.

Work has been done by @guerrerotook and @asishv

So the remaining items are

  • Uploading youtube videos
  • Obtaining categories [@guerrerotook mentioned that this is working but I was not able to use it]
  • Adding new categories to a post
  • Testing edge cases in general
  • Code cleanup [I believe the wizard strings are hardcoded in the code not in strings.resx file]

@willduff, @wasker, @RobDolin, @SiTox, @Eilon

@gene7299

This comment has been minimized.

Show comment
Hide comment
@gene7299

gene7299 Dec 11, 2015

How about the image uploading to Google Photos?

How about the image uploading to Google Photos?

@ericasisme

This comment has been minimized.

Show comment
Hide comment
@ericasisme

ericasisme Dec 12, 2015

Issue #63 is a related issue, with many users commenting that they are getting an error when trying to log into Blogger. I am also getting the error and am adding the comment to this bug.

Environment: Windows 10

Steps to reproduce:

  1. Download and install OLW
  2. Connect to your blogger blog
  3. OLW not able to automatically detect settings
    3a. Select 'Blogger'
    3b. Remote pasting field is auto-populated (I do not know if this is correct, it says
    http://www.blogger.com/feeds/default/blogs
  4. Get user name / password incorrect Error

Issue #63 is a related issue, with many users commenting that they are getting an error when trying to log into Blogger. I am also getting the error and am adding the comment to this bug.

Environment: Windows 10

Steps to reproduce:

  1. Download and install OLW
  2. Connect to your blogger blog
  3. OLW not able to automatically detect settings
    3a. Select 'Blogger'
    3b. Remote pasting field is auto-populated (I do not know if this is correct, it says
    http://www.blogger.com/feeds/default/blogs
  4. Get user name / password incorrect Error
@ronmartmsft

This comment has been minimized.

Show comment
Hide comment
@ronmartmsft

ronmartmsft Dec 12, 2015

This could not have happened at a worse time given how many bloggers rely on the holiday season for income. It seems that Google has taken the release of this product as a green light to finally deprecate the legacy auth leaving Blogger users stranded.

Track here - https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/blogger/lw_sNsyySKI/FyMxf1DBBwAJ

If you guys have any Google contacts, please ask them to reconsider this until after the holiday season and turn back on the legacy support.

This could not have happened at a worse time given how many bloggers rely on the holiday season for income. It seems that Google has taken the release of this product as a green light to finally deprecate the legacy auth leaving Blogger users stranded.

Track here - https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/blogger/lw_sNsyySKI/FyMxf1DBBwAJ

If you guys have any Google contacts, please ask them to reconsider this until after the holiday season and turn back on the legacy support.

This was referenced Dec 14, 2015

This was referenced Dec 14, 2015

willduff added a commit that referenced this issue Dec 16, 2015

Merge pull request #101 from willduff/google-blogger
Issue #5 - Convert Google Blogger ClientLogin to OAuth 2.0
@willduff

This comment has been minimized.

Show comment
Hide comment
@willduff

willduff Dec 16, 2015

Member

Good news everyone, I just finished coding initial support for Google Blogger in Open Live Writer. I have a 'nightly' build for those that are willing to try out pre-release software. Please let me know if you see any issues, other than the known ones below.

Known issues:

  • You need to remove your old Google Blogger accounts from Open Live Writer first. After removing them, click the 'Add blog account...' button in Open Live Writer to set up your Google Blogger accounts.
  • Scheduling a published post may be a few hours off.
  • Categories are no longer supported in the latest Blogger API v3.
  • Support for authors, tags and comment policies is not enabled yet.
  • Attempting to login to Google Blogger with 0 blogs will show an error message. Please create a blog on http://www.blogger.com first before using Open Live Writer.

The download link is: https://olw.blob.core.windows.net/nightly/Releases/OpenLiveWriterSetup.exe

/cc
@ronmartmsft, @gene7299

Member

willduff commented Dec 16, 2015

Good news everyone, I just finished coding initial support for Google Blogger in Open Live Writer. I have a 'nightly' build for those that are willing to try out pre-release software. Please let me know if you see any issues, other than the known ones below.

Known issues:

  • You need to remove your old Google Blogger accounts from Open Live Writer first. After removing them, click the 'Add blog account...' button in Open Live Writer to set up your Google Blogger accounts.
  • Scheduling a published post may be a few hours off.
  • Categories are no longer supported in the latest Blogger API v3.
  • Support for authors, tags and comment policies is not enabled yet.
  • Attempting to login to Google Blogger with 0 blogs will show an error message. Please create a blog on http://www.blogger.com first before using Open Live Writer.

The download link is: https://olw.blob.core.windows.net/nightly/Releases/OpenLiveWriterSetup.exe

/cc
@ronmartmsft, @gene7299

@aabelro

This comment has been minimized.

Show comment
Hide comment
@aabelro

aabelro Dec 16, 2015

It works! Thank you.
The only problem that noticed was that having multiple blogs (6), OLW kept sending an access permission request to Blogger and I had to acknowledge it for every blog. It was not a real problem, just that I suppose Blogger needs to authorize OLW just one time.

aabelro commented Dec 16, 2015

It works! Thank you.
The only problem that noticed was that having multiple blogs (6), OLW kept sending an access permission request to Blogger and I had to acknowledge it for every blog. It was not a real problem, just that I suppose Blogger needs to authorize OLW just one time.

@SteveP-UK

This comment has been minimized.

Show comment
Hide comment
@SteveP-UK

SteveP-UK Dec 16, 2015

Works for me too! #OLW

Works for me too! #OLW

@kathweaver

This comment has been minimized.

Show comment
Hide comment
@kathweaver

kathweaver Dec 16, 2015

Contributor

Works for me. However, I only have Blogger account. Everything appears to be working!

Contributor

kathweaver commented Dec 16, 2015

Works for me. However, I only have Blogger account. Everything appears to be working!

@willduff

This comment has been minimized.

Show comment
Hide comment
@willduff

willduff Dec 16, 2015

Member

@aabelro Yes, this was a tradeoff I made for simplicity in the case where a user only has one blog. It's something we could look into making more effortless in the future though, thank you for the feedback.

@SteveP-UK and @kathweaver - Thank you for testing!

Member

willduff commented Dec 16, 2015

@aabelro Yes, this was a tradeoff I made for simplicity in the case where a user only has one blog. It's something we could look into making more effortless in the future though, thank you for the feedback.

@SteveP-UK and @kathweaver - Thank you for testing!

@ericasisme

This comment has been minimized.

Show comment
Hide comment
@ericasisme

ericasisme Dec 17, 2015

It seems to be working! Thank you so much! I just put words and pictures
and publish.
The other night I didn't make it as far as the interface. It's great that
the GUI is exactly the same as the last version of WLW. A lot of times
Open Source stuff I've seen looks really different, and glad to see this
pick up where WLW left off!
The only thing that was a little weird was I was already logged into Google
in Chrome, but it asked me to log into the new e with Windows 10 (I forget
the name) and give OLW permission. It was no big deal and it connected
just fine, I just mention it in case it's not the expected behavior.

On Wed, Dec 16, 2015 at 5:55 PM, Will Duff notifications@github.com wrote:

@aabelro https://github.com/aabelro Yes, this was a tradeoff I made for
simplicity in the case where a user only has one blog. It's something we
could look into making more effortless in the future though, thank you for
the feedback.

@SteveP-UK https://github.com/SteveP-UK and @kathweaver
https://github.com/kathweaver - Thank you for testing!


Reply to this email directly or view it on GitHub
#5 (comment)
.

It seems to be working! Thank you so much! I just put words and pictures
and publish.
The other night I didn't make it as far as the interface. It's great that
the GUI is exactly the same as the last version of WLW. A lot of times
Open Source stuff I've seen looks really different, and glad to see this
pick up where WLW left off!
The only thing that was a little weird was I was already logged into Google
in Chrome, but it asked me to log into the new e with Windows 10 (I forget
the name) and give OLW permission. It was no big deal and it connected
just fine, I just mention it in case it's not the expected behavior.

On Wed, Dec 16, 2015 at 5:55 PM, Will Duff notifications@github.com wrote:

@aabelro https://github.com/aabelro Yes, this was a tradeoff I made for
simplicity in the case where a user only has one blog. It's something we
could look into making more effortless in the future though, thank you for
the feedback.

@SteveP-UK https://github.com/SteveP-UK and @kathweaver
https://github.com/kathweaver - Thank you for testing!


Reply to this email directly or view it on GitHub
#5 (comment)
.

@ronaero1

This comment has been minimized.

Show comment
Hide comment
@ronaero1

ronaero1 Dec 17, 2015

Receiving the following error while trying to access "Local Drafts" or "Open recent Posts"! Any subjestions?

Thursday, December 17, 2015 12:53:34 AM

Version: 0.5.1.2

OS Version: Microsoft Windows NT 6.1.7601 Service Pack 1
Runtime version: 4.0.30319.34209
Shutdown started: False
Program: "C:\Users\Main\AppData\Local\OpenLiveWriter\app-0.5.1.2\OpenLiveWriter.exe" --squirrel-firstrun

Memory Load: 50%
Total Physical: 8063 MB
Available Physical: 3967 MB
Total Page File: 8561 MB
Available Page File: 4167 MB
Total Virtual: 2047 MB
Available Virtual: 1604 MB
Available Extented Virtual: 0 MB

Unexpected Error Occurred
An unexpected error has occurred within the application.

OpenLiveWriter.PostEditor.PostEditorStorageException: Error Accessing Local Post - Unexpected error occurred while accessing local post (UnauthorizedAccessException)

Access to the path 'C:\Users\Main\AppData\Local\Temp\OpenLiveWriter1257078411\supfilesE0326AB\SpellingContext' is denied.
at OpenLiveWriter.PostEditor.PostEditorFile.Load(Boolean addToRecentDocs)
at OpenLiveWriter.PostEditor.BlogPostEditingManager.OpenLocalPost(PostInfo postInfo)
at OpenLiveWriter.PostEditor.PostEditorMainControl.OpenLiveWriter.PostEditor.IBlogPostEditingSite.OpenLocalPost(PostInfo postInfo)
at OpenLiveWriter.PostEditor.Commands.DraftPostItemsGalleryCommand.DraftPostItemsGalleryCommand_Execute(Object sender, EventArgs e)
at OpenLiveWriter.ApplicationFramework.Command.RaiseEvent(Object eventKey, EventArgs e)
at OpenLiveWriter.ApplicationFramework.Command.OnExecute(EventArgs e)

Receiving the following error while trying to access "Local Drafts" or "Open recent Posts"! Any subjestions?

Thursday, December 17, 2015 12:53:34 AM

Version: 0.5.1.2

OS Version: Microsoft Windows NT 6.1.7601 Service Pack 1
Runtime version: 4.0.30319.34209
Shutdown started: False
Program: "C:\Users\Main\AppData\Local\OpenLiveWriter\app-0.5.1.2\OpenLiveWriter.exe" --squirrel-firstrun

Memory Load: 50%
Total Physical: 8063 MB
Available Physical: 3967 MB
Total Page File: 8561 MB
Available Page File: 4167 MB
Total Virtual: 2047 MB
Available Virtual: 1604 MB
Available Extented Virtual: 0 MB

Unexpected Error Occurred
An unexpected error has occurred within the application.

OpenLiveWriter.PostEditor.PostEditorStorageException: Error Accessing Local Post - Unexpected error occurred while accessing local post (UnauthorizedAccessException)

Access to the path 'C:\Users\Main\AppData\Local\Temp\OpenLiveWriter1257078411\supfilesE0326AB\SpellingContext' is denied.
at OpenLiveWriter.PostEditor.PostEditorFile.Load(Boolean addToRecentDocs)
at OpenLiveWriter.PostEditor.BlogPostEditingManager.OpenLocalPost(PostInfo postInfo)
at OpenLiveWriter.PostEditor.PostEditorMainControl.OpenLiveWriter.PostEditor.IBlogPostEditingSite.OpenLocalPost(PostInfo postInfo)
at OpenLiveWriter.PostEditor.Commands.DraftPostItemsGalleryCommand.DraftPostItemsGalleryCommand_Execute(Object sender, EventArgs e)
at OpenLiveWriter.ApplicationFramework.Command.RaiseEvent(Object eventKey, EventArgs e)
at OpenLiveWriter.ApplicationFramework.Command.OnExecute(EventArgs e)

@martinwoodward

This comment has been minimized.

Show comment
Hide comment
@martinwoodward

martinwoodward Dec 17, 2015

Member

@ericasisme - if Edge is your default browser (which it is by default on Windows 10) then the behavior you describe is expected. Great to hear that you are up and running

Member

martinwoodward commented Dec 17, 2015

@ericasisme - if Edge is your default browser (which it is by default on Windows 10) then the behavior you describe is expected. Great to hear that you are up and running

@martinwoodward

This comment has been minimized.

Show comment
Hide comment
@martinwoodward

martinwoodward Dec 17, 2015

Member

@ronaero1 - I think you are running into issue #26. Still need a fix for that one.

Member

martinwoodward commented Dec 17, 2015

@ronaero1 - I think you are running into issue #26. Still need a fix for that one.

@StephenCWLL

This comment has been minimized.

Show comment
Hide comment
@StephenCWLL

StephenCWLL Dec 17, 2015

Sorry, I'm a bit late as wasn't near a computer yesterday!

Just installed it (I uninstalled previous version first).

Not published or edited anything yet. I'm all signed in thanks with blogger, so that's much better :)

Couple of installation notes:

Edge reports downloading your exe as "Unsafe". Didn't take screenshot :( But think it's due to the same reason as next note below. Edge is my default browser.
Smartscreen pops up a blue warning message that the application is unrecognised and giving you the choice to run or not run it. Think this is because there's no publisher information for the exe.
ss
The Edge window that popped up for Google Blogger Authentication didn't close automatically afterwards. Edge is my default browser.
Also noticed it won't open my recent post (which I think I did open last in WLW) with the same error as that chap for before. i.e. the Edge issue.

More later when I get to play with it :) Thanks for your work thus far.

Sorry, I'm a bit late as wasn't near a computer yesterday!

Just installed it (I uninstalled previous version first).

Not published or edited anything yet. I'm all signed in thanks with blogger, so that's much better :)

Couple of installation notes:

Edge reports downloading your exe as "Unsafe". Didn't take screenshot :( But think it's due to the same reason as next note below. Edge is my default browser.
Smartscreen pops up a blue warning message that the application is unrecognised and giving you the choice to run or not run it. Think this is because there's no publisher information for the exe.
ss
The Edge window that popped up for Google Blogger Authentication didn't close automatically afterwards. Edge is my default browser.
Also noticed it won't open my recent post (which I think I did open last in WLW) with the same error as that chap for before. i.e. the Edge issue.

More later when I get to play with it :) Thanks for your work thus far.

@romona

This comment has been minimized.

Show comment
Hide comment
@romona

romona Dec 17, 2015

Thank you Will and everyone who made OLW work with Blogger. It's really appreciated. I created a test blog and did some customizing on the page, uploaded a test post etc. The only thing I've found so far that I can't change, is the font in the title of the post. It's defaults to Arial. The font box greys out and will only allow that one font. Other than that, so far, all seems well. Will continue to use the original one for a while yet to see what else might change in the open source version. But thanks again, so glad this is now working... Romona

romona commented Dec 17, 2015

Thank you Will and everyone who made OLW work with Blogger. It's really appreciated. I created a test blog and did some customizing on the page, uploaded a test post etc. The only thing I've found so far that I can't change, is the font in the title of the post. It's defaults to Arial. The font box greys out and will only allow that one font. Other than that, so far, all seems well. Will continue to use the original one for a while yet to see what else might change in the open source version. But thanks again, so glad this is now working... Romona

@StephenCWLL

This comment has been minimized.

Show comment
Hide comment
@StephenCWLL

StephenCWLL Dec 17, 2015

Just written a blog purely from OLW, went to publish it, and I get this:

The remote server returned an error: (403) Forbidden.

It won't even upload a draft atm. It was earlier when I was playing about.

Just written a blog purely from OLW, went to publish it, and I get this:

The remote server returned an error: (403) Forbidden.

It won't even upload a draft atm. It was earlier when I was playing about.

@ScottIsAFool

This comment has been minimized.

Show comment
Hide comment
Member

ScottIsAFool commented Dec 17, 2015

@StephenCWLL

This comment has been minimized.

Show comment
Hide comment
@StephenCWLL

StephenCWLL Dec 17, 2015

Ha! Yeah, I'd just done that before I was coming back here to say I'd fixed it :) Thanks though. That did the trick. Great minds think alike ;O)

Ha! Yeah, I'd just done that before I was coming back here to say I'd fixed it :) Thanks though. That did the trick. Great minds think alike ;O)

@willduff

This comment has been minimized.

Show comment
Hide comment
@willduff

willduff Dec 17, 2015

Member

Hey @StephenCWLL, I'd be interested to see your log file to investigate the (403) Forbidden error. Can you launch Open Live Writer, then go to File | About | Show log file and email the log file to openlivewriter-team@dotnetfoundation.org? Thanks!

Member

willduff commented Dec 17, 2015

Hey @StephenCWLL, I'd be interested to see your log file to investigate the (403) Forbidden error. Can you launch Open Live Writer, then go to File | About | Show log file and email the log file to openlivewriter-team@dotnetfoundation.org? Thanks!

@willduff

This comment has been minimized.

Show comment
Hide comment
@willduff

willduff Dec 17, 2015

Member

Actually, I was able to repro the (403) Forbidden error myself. Seems to be a re-authorization issue, I'll look into it.

Member

willduff commented Dec 17, 2015

Actually, I was able to repro the (403) Forbidden error myself. Seems to be a re-authorization issue, I'll look into it.

@willduff

This comment has been minimized.

Show comment
Hide comment
@willduff

willduff Dec 17, 2015

Member

Fixed with pull request #101.

Member

willduff commented Dec 17, 2015

Fixed with pull request #101.

@willduff willduff closed this Dec 17, 2015

@StephenCWLL

This comment has been minimized.

Show comment
Hide comment
@StephenCWLL

StephenCWLL Dec 17, 2015

@willduff Dude, I didn't even have time to read your message :p Ok, I'll leave you to it then :)

@willduff Dude, I didn't even have time to read your message :p Ok, I'll leave you to it then :)

@way0utwest

This comment has been minimized.

Show comment
Hide comment
@way0utwest

way0utwest Dec 24, 2015

First, thank you all for the work done here. Once again, I can write offline and publish to multiple Blogger blogs from OLW. I very much appreciate your efforts.

Second, Merry Christmas and Happy Holidays. You've given me a great gift with your efforts here and I hope you enjoy your holidays.

First, thank you all for the work done here. Once again, I can write offline and publish to multiple Blogger blogs from OLW. I very much appreciate your efforts.

Second, Merry Christmas and Happy Holidays. You've given me a great gift with your efforts here and I hope you enjoy your holidays.

@ericasisme

This comment has been minimized.

Show comment
Hide comment
@ericasisme

ericasisme Dec 30, 2015

I just got that error tonight. What is the fix?

On Thu, Dec 17, 2015 at 11:55 AM, Will Duff notifications@github.com
wrote:

Hey @StephenCWLL https://github.com/StephenCWLL, I'd be interested to
see your log file to investigate the (403) Forbidden error. Can you launch
Open Live Writer, then go to File | About | Show log file and email
the log file to mailto:openlivewriter-team@dotnetfoundation.org? Thanks!


Reply to this email directly or view it on GitHub
#5 (comment)
.

I just got that error tonight. What is the fix?

On Thu, Dec 17, 2015 at 11:55 AM, Will Duff notifications@github.com
wrote:

Hey @StephenCWLL https://github.com/StephenCWLL, I'd be interested to
see your log file to investigate the (403) Forbidden error. Can you launch
Open Live Writer, then go to File | About | Show log file and email
the log file to mailto:openlivewriter-team@dotnetfoundation.org? Thanks!


Reply to this email directly or view it on GitHub
#5 (comment)
.

@kathweaver

This comment has been minimized.

Show comment
Hide comment
@kathweaver

kathweaver Dec 30, 2015

Contributor

Do you have the latest version of OpenLiveWriter? You can check by looking at File About page. We're at Build 0.5.1.4

Contributor

kathweaver commented Dec 30, 2015

Do you have the latest version of OpenLiveWriter? You can check by looking at File About page. We're at Build 0.5.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment