Fix issue with spaces in username #239

Merged
merged 1 commit into from Dec 24, 2015

Projects

None yet

4 participants

@jmbucknall
Contributor

For reasons lost in time my username on my laptop has spaces. That means
%LocalAppData% will also have spaces. That means calls to exes in
LocalAppData must be quoted. The build.cmd batch file will fail without
such quoted exe names. (Ditto createinstaller.cmd)

@jmbucknall jmbucknall Fix issue with spaces in username
For reasons lost in time my username on my laptop has spaces. That means
%LocalAppData% will also have spaces. That means calls to exes in
LocalAppData must be quoted. The build.cmd batch file will fail without
such quoted exe names.
f774702
@dnfclas
dnfclas commented Dec 24, 2015

Hi @jmbucknall, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
dnfclas commented Dec 24, 2015

@jmbucknall, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added cla-signed and removed cla-required labels Dec 24, 2015
@ScottIsAFool
Member

Ugh, I thought we'd caught all of these. Thanks.

@ScottIsAFool ScottIsAFool merged commit 7cacaea into OpenLiveWriter:master Dec 24, 2015

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peteraritchie

for reasons lost in time do spaces never get supported in scripts from the start :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment