New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][New Provider] Support GitHub Page (Jekyll) #242

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
10 participants
@rebornix

rebornix commented Dec 24, 2015

As described in #55 , there are millions of sites using GitHub Page as their blog engine, we may want to add GitHub Page to the default supported blog list. This feature is still in progress, I just send out this pr for community review. It already supports CRUD of pages but as OLW is lack of Markdown support for now, so you can't really publish one working markdown post to GitHub Page, but I suppose we don't need to wait for too long.

TODO:

  • Basic Authentication.
  • OAuth 2.0
  • Markdown Support ( this task is actually external )
  • CRUD for posts ( _post\year-month-day-title.md)
  • CRUD for drafts (_drafts\title.md)
  • Metadata basic support ( Categories, Tags, Date, Excerpt )
  • Metadata UI part ( In Jekyll we store metadata at the beginning of markdown file, aka Yaml Front Matter, we need to map it to UI control like how we deal with Categories )
  • Consistent error handling
  • Code clean up.
  • Unit Test

Last but not least, allow me say thank you to @robertiagar @pekiZG @JohnBlood @lankaapura and @SummerSun, we can't have this pr without your input 馃槃 . As we still have a lot of detailed work to do, I'm really looking forward to your help on this feature, if you are happy to contribute, you can start with issues marked as easyfix in my fork.

@robertiagar

This comment has been minimized.

Show comment
Hide comment
@robertiagar

robertiagar Dec 17, 2015

Json2Csharp?

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Dec 17, 2015

Owner

Good catch, I'll clean this up once I know which properties aren't useful 馃憤

Owner

rebornix replied Dec 17, 2015

Good catch, I'll clean this up once I know which properties aren't useful 馃憤

This comment has been minimized.

Show comment
Hide comment
@pekiZG

pekiZG Dec 17, 2015

@here:
I was thinking on using it in JsonBlogClient.

pekiZG replied Dec 17, 2015

@here:
I was thinking on using it in JsonBlogClient.

This comment has been minimized.

Show comment
Hide comment
@rebornix
Owner

rebornix replied Dec 17, 2015

This comment has been minimized.

Show comment
Hide comment
@pekiZG

pekiZG Dec 17, 2015

As I understand I have to return Json payload and not XML.
Right?

And of course I can try it with local ghost blog

pekiZG replied Dec 17, 2015

As I understand I have to return Json payload and not XML.
Right?

And of course I can try it with local ghost blog

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Dec 17, 2015

Owner

Correct, json is the biggest difference.

Owner

rebornix replied Dec 17, 2015

Correct, json is the biggest difference.

@pekiZG

This comment has been minimized.

Show comment
Hide comment
@pekiZG

pekiZG Dec 17, 2015

Will pull it today and start workign on JsonBlogClient for ghost.

pekiZG commented on 648043b Dec 17, 2015

Will pull it today and start workign on JsonBlogClient for ghost.

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Dec 17, 2015

Owner

@robertiagar as you take the YAML/Jekyll tasks, you might be interested in these two TODOs.

@robertiagar as you take the YAML/Jekyll tasks, you might be interested in these two TODOs.

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Dec 25, 2015

Map Jekyll metadata to existing UI controls, eg Categories, Tags, Excerpt...

image

rebornix commented Dec 25, 2015

Map Jekyll metadata to existing UI controls, eg Categories, Tags, Excerpt...

image

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Dec 28, 2015

Finish front matter part, which is already metadata standard in Static Site Generators.

image

rebornix commented Dec 28, 2015

Finish front matter part, which is already metadata standard in Static Site Generators.

image

@robertiagar

This comment has been minimized.

Show comment
Hide comment
@robertiagar

robertiagar Dec 28, 2015

This looks great!

robertiagar commented Dec 28, 2015

This looks great!

@crlf0710

This comment has been minimized.

Show comment
Hide comment
@crlf0710

crlf0710 Jan 21, 2016

Hi, how the progress on this? i noticed that the ci build is failed but there's no obvious error. any chance to rerun the build?

crlf0710 commented Jan 21, 2016

Hi, how the progress on this? i noticed that the ci build is failed but there's no obvious error. any chance to rerun the build?

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Jan 21, 2016

@crlf0710 this pr passed all checks when I sent it out but as I'm waiting for @dend 's markdown integration, I didn't do any rebase or sync with upstream, so the checks failure is expected.

Once we have markdown in mainstream, I'll update this PR ASAP then we can have a happy pass of GitHub Page integration.

rebornix commented Jan 21, 2016

@crlf0710 this pr passed all checks when I sent it out but as I'm waiting for @dend 's markdown integration, I didn't do any rebase or sync with upstream, so the checks failure is expected.

Once we have markdown in mainstream, I'll update this PR ASAP then we can have a happy pass of GitHub Page integration.

@dend

This comment has been minimized.

Show comment
Hide comment
@dend

dend Jan 21, 2016

Rushing to finish my MD work - have a publishing bug that I need to fix related to sending the data to the engine. Once that is done, should be good to go.

dend commented Jan 21, 2016

Rushing to finish my MD work - have a publishing bug that I need to fix related to sending the data to the engine. Once that is done, should be good to go.

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Jan 21, 2016

Thanks @dend , really looking forward to your work! No hurries 馃憤

rebornix commented Jan 21, 2016

Thanks @dend , really looking forward to your work! No hurries 馃憤

@japj

This comment has been minimized.

Show comment
Hide comment
@japj

japj Feb 19, 2016

Hi, what is the current state of this? Anything that I can help with?

japj commented Feb 19, 2016

Hi, what is the current state of this? Anything that I can help with?

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Feb 19, 2016

@japj I'm waiting for @dend 's markdown integration actually. Once it's done, we can continue this pr 馃槃

rebornix commented Feb 19, 2016

@japj I'm waiting for @dend 's markdown integration actually. Once it's done, we can continue this pr 馃槃

@dend

This comment has been minimized.

Show comment
Hide comment
@dend

dend Feb 20, 2016

@rebornix ok, sorry for the delay 馃憤 I finally figured out what the problem is with the bug in the MD publishing, checking it in this week 馃槃

dend commented Feb 20, 2016

@rebornix ok, sorry for the delay 馃憤 I finally figured out what the problem is with the bug in the MD publishing, checking it in this week 馃槃

@japj

This comment has been minimized.

Show comment
Hide comment
@japj

japj Mar 2, 2016

@dend anything we can do to help this move forward?

japj commented Mar 2, 2016

@dend anything we can do to help this move forward?

@jongio

This comment has been minimized.

Show comment
Hide comment
@jongio

jongio Apr 26, 2016

@dend Thanks a lot for getting this started. We'd like to get this wrapped @up so we can enable static-sites. Do you have an ETA or can you push what you have to date to a branch so we can take this forward?

Thanks,
Jon

jongio commented Apr 26, 2016

@dend Thanks a lot for getting this started. We'd like to get this wrapped @up so we can enable static-sites. Do you have an ETA or can you push what you have to date to a branch so we can take this forward?

Thanks,
Jon

@RobDolinMS

This comment has been minimized.

Show comment
Hide comment
@RobDolinMS

RobDolinMS Aug 30, 2016

Contributor

THANK YOU @rebornix, @dend, and others for working on this. EXCITING!

Contributor

RobDolinMS commented Aug 30, 2016

THANK YOU @rebornix, @dend, and others for working on this. EXCITING!

@OpenLiveWriter OpenLiveWriter deleted a comment from dnfclas Dec 6, 2017

@japj

This comment has been minimized.

Show comment
Hide comment
@japj

japj Dec 15, 2017

What is the current progress of Jekyll support? How can I help to move this forward again?

japj commented Dec 15, 2017

What is the current progress of Jekyll support? How can I help to move this forward again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment