From dd32023bab0e6b85f897fa9f358bb9456ac7b042 Mon Sep 17 00:00:00 2001 From: swryan Date: Wed, 15 Nov 2023 08:35:46 -0500 Subject: [PATCH] clean up warnings and exit codes in github workflows --- .github/workflows/openmdao_audit.yml | 5 ++--- .github/workflows/openmdao_latest_workflow.yml | 2 +- .github/workflows/openmdao_test_workflow.yml | 7 +++---- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/openmdao_audit.yml b/.github/workflows/openmdao_audit.yml index 36b2365da5..7e018a1e17 100644 --- a/.github/workflows/openmdao_audit.yml +++ b/.github/workflows/openmdao_audit.yml @@ -119,9 +119,8 @@ jobs: python -m pip_audit -s osv --ignore-vuln GHSA-hcpj-qp55-gfph - name: Notify slack - uses: act10ns/slack@v1.6.0 - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + uses: act10ns/slack@v2.0.0 with: + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} status: ${{ job.status }} if: failure() diff --git a/.github/workflows/openmdao_latest_workflow.yml b/.github/workflows/openmdao_latest_workflow.yml index 6e199a59a4..1302b4d5b9 100644 --- a/.github/workflows/openmdao_latest_workflow.yml +++ b/.github/workflows/openmdao_latest_workflow.yml @@ -239,7 +239,7 @@ jobs: echo 'EOF' >> $GITHUB_OUTPUT - grep changed $GITHUB_OUTPUT + grep changed $GITHUB_OUTPUT || echo "" if: always() diff --git a/.github/workflows/openmdao_test_workflow.yml b/.github/workflows/openmdao_test_workflow.yml index c445ad7591..9520c3b8f2 100644 --- a/.github/workflows/openmdao_test_workflow.yml +++ b/.github/workflows/openmdao_test_workflow.yml @@ -294,7 +294,7 @@ jobs: echo 'EOF' >> $GITHUB_OUTPUT - grep changed $GITHUB_OUTPUT + grep changed $GITHUB_OUTPUT || echo "" - name: Setup tmate session if: matrix.DEBUG @@ -414,10 +414,9 @@ jobs: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - name: Notify slack - uses: act10ns/slack@v1.6.0 - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + uses: act10ns/slack@v2.0.0 with: + webhook-url: ${{ secrets.SLACK_WEBHOOK_URL }} status: ${{ job.status }} if: always()