Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N2 detecting offscreen connections #1114

Merged
merged 6 commits into from Nov 13, 2019
Merged

Conversation

tadkollar
Copy link
Member

N2 can now tell whether a connection exists offscreen and where it should be drawn. Does not actually draw the connection, yet (separate story). Drawing the arrow will be easy, but labeling, especially when there are a lot of persistent ones, could be a problem.

Originally I intended to precompute the matrix once and find connections from that, but that wasn't useful because collapsing and searching causes too many changes. Offscreen connections are now computed every time the matrix is rebuilt.

Added ability to toggle debugging messages in defaults.js.
Changed matrix cell dimensions to a static object in N2CellRenderer.
@tadkollar
Copy link
Member Author

I'm not sure why the appveyor Python 2.7 test is failing, there aren't any Python changes in this PR

@swryan
Copy link
Contributor

swryan commented Nov 12, 2019

I'm not sure why the appveyor Python 2.7 test is failing, there aren't any Python changes in this PR

most likely a change in underlying conda packages.. I'll see what I can figure out

@swryan swryan merged commit 676aeb5 into OpenMDAO:master Nov 13, 2019
@tadkollar tadkollar deleted the n2conn2 branch November 13, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants