Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were a couple of things causing the memory leak in
Group._get_scope()
. The big one was that_scope_cache
was using refs to subsystem instances as dict keys. So when they were dereferenced elsewhere duringsetup()
, the_scope_cache
dict still held refs to the old objects because there's no automatic way to clear it out.Initially, I addressed this by using the
id()
of the subsystem objects as dict keys, but there was still a small leak. This was because following asetup()
, the subsystem instances were different even if the info in_scope_cache
was the same. I ended up using the subsystem pathname as the key, and testing on cache hits to make sure it still referred to the same object.I added a test that runs
setup()
10 times and then 100 times and checks for differences in memory usage afterwards. If the difference is more than 10k, it fails.Related Issues