-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comet executable version differs in quay container and repo #106
Comments
comet-ms bioconda is at 2023010-2 so this seems recent |
Yes, update and rebuild is the safest. |
Looks like the most recent release of comet is not on bioconda.. https://github.com/bioconda/bioconda-recipes/blob/c47bb585be9496842599e2e512a35dd120239528/recipes/comet-ms/meta.yaml#L10 So first we need to update that one and then rebuild. I can update comet and see if a simple version bump helps. |
Comet executable in recent container quay.io/biocontainers/openms-thirdparty:3.1.0--h9ee0642_3 differs from the one in this repo.
Container version:
TOPPBase.cpp(1588): Comet Version extracted is: '# comet_version 2023.01 rev. 0
Version in this repo:
TOPPBase.cpp(1630): Comet Version extracted is: '# comet_version 2023.01 rev. 2 (7c9150d)
Not sure how that could happen. @timosachsenberg Any ideas? They comet executable was exchanged a year ago --> commit
before the 3.1.0 release.
The most recent comet version is needed to make sure the
pin
output andpepxml
output of comet are the same. For more information see releaseLet me know if I can assist with anything
The text was updated successfully, but these errors were encountered: