Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
New option in settings allowing to add multiple identical effects in spellcreation #1076
This small pull request adds option in settings to disable checking for identical effects in spell creation.
This makes it possible to for example create spells with both:
old forum thread: https://forum.openmw.org/viewtopic.php?f=2&t=3545
OpenMW before 1.0 is supposed to be replacement of vanilla engine, so I needed to make this behavior optional. That's why it's in settings.
If we were already over 1.0, then I would have advocated to just remove the part of code that checks for identical effects altogether. Because its only purpose seems to be to force player to create fireballs that freeze/electrocute enemy over time...
OpenMW post-1.0 is still going to be a vanilla engine replacement. It's not as if after 1.0 we're going to do anything to break Morrowind or significantly alter support beyond improving what it's capable of (playing Morrowind unmodded, OpenMW post-1.0 should mechanically be the same as 1.0). It's just a matter of encouraging people to put the effort into working on extra features (pre-1.0, people should focus on getting the missing vanilla features implemented to get to 1.0 faster, instead of taking time with new features). Given that you've already put the effort into coding it though, in my opinion the question becomes if it's a feature OpenMW wants at all and if it's good enough to put in (in particular, does it break balancing? are multiple identical effects cheaper than one effect with the same combined strength?).
IMO, if it's good enough to have on by default after 1.0, it's good enough to have on by default before 1.0, given that it's already coded. If it's not good enough to have on by default after 1.0, then I don't think a settings option is the right way to go about it regardless.
Cost: 100, Chance: 25, Price: 787
Cost: 100, Chance: 25, Price: 788
Spell_eight (max number):
Cost: 101, Chance: 24, Price: 795
Tested with Willpower=100, Destruction=50
Thankfully it doesn't break balancing at all. I have also not noticed any bugs that this would create while testing it.