New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display weapon reach on tooltips in feet #1707

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
4 participants
@akortunov
Contributor

akortunov commented May 16, 2018

With "show melee info = true" OpenMW displays weapon reach on the tooltip in percents (Reach 1.0 means 100%).
With this PR OpenMW will calculate reach in feet using fCombatDistance GMST:

screenshot_20180516_111146

Notes:

  1. 1 yard = 3 feet = 64 game units
  2. With default fCombatDistance = 128 Reach = 1.0 means 6 ft combat distance.
@psi29a

This comment has been minimized.

Member

psi29a commented May 16, 2018

Nice, was this something in Morrowind of just something extra?

@akortunov

This comment has been minimized.

Contributor

akortunov commented May 16, 2018

Nice, was this something in Morrowind of just something extra?

IIRC, something extra, even if we will compare with MCP.
Morrowind uses the Reach value, but does not show it in-game.
It is weird because some mods alter Reach values for some weapons.

@psi29a

This comment has been minimized.

Member

psi29a commented May 16, 2018

I like it, not really feature creep imho since the info is there anyway. It's not immersion breaking, because your character can probably also guess how long a weapon is.

I'll merge it. Thanks.

@psi29a psi29a merged commit caf1760 into OpenMW:master May 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jvoisin

This comment has been minimized.

Contributor

jvoisin commented May 16, 2018

What about using the metric system instead :/

@akortunov

This comment has been minimized.

Contributor

akortunov commented May 16, 2018

What about using the metric system instead :/

Unfortunately, the whole game uses imperial units (foot, pound, yard, etc.).

@kcat

This comment has been minimized.

Contributor

kcat commented May 16, 2018

Unfortunately, the whole game uses imperial units (foot, pound, yard, etc.).

Not hard to convert feet to meters. meters = feet * 0.3048

@akortunov

This comment has been minimized.

Contributor

akortunov commented May 16, 2018

Not hard to convert feet to meters. meters = feet * 0.3048

Units conversion is probably a separate feature request and should be discussed on forum instead of here.
Keep in mind that:

  1. Imperial->metric conversion result is usually irrational number and often will not look good even with rounding.
  2. We have no GMSTs for metric units.
  3. Probably it should be optional.
@psi29a

This comment has been minimized.

Member

psi29a commented May 16, 2018

I thought about this myself, but the game is based around imperial units of measurements... devs probably left that out for the end-user so they wouldn't have to deal with localization (imperial->metric).

Display in Metric is out of scope, for now. We'll likely want to support metric in the future.

@akortunov akortunov deleted the akortunov:weaponreach branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment