Weapon types de-hardcoding

[akortunov]

Changes custom bones loading, so requires new skeleton meshes for weapon sheathing: Sheath.zip

Summary of changes:

1. Moves most of weapontype-related logic from a lot of switches and if-s to the table.
   In theory, later we can move this table to ESM or some kind of logic. This approach will allow modders to add new weapon types with new animations (one-handed spears or magic sword which requires Destruction skill instead of Long Blades, for example) or modify existing ones (move bow to the left hand or add a separate set of animations for short blades, for example).

2. Changes custom bones loading.
   Instead of hardcoded xbase_anim_sh.nif OpenMW will scan nifs in the Animation folder and will load any node marked with "BONE" NiStringExtraData. Optimizer will not remove such nodes.
   This approach allows to tweak new nodes differently for females, beast races, etc.
   Here I just rotated sheathing bone for beast races only (left - old behaviour, right - new behaviour):
   

Related forum topic.

[akortunov]

And if anyone is interested, here is the prototype of bow in the left hand: Left.zip

openmw.cfg:

weapon-type=9;Bow;2b;bowandarrow;Item Weapon Bow;Weapon Bone Left;Bip01 MarksmanBow;23;1;12;1

settings.cfg:

[Game]
use additional anim sources = true

Basically, ZIP-archive contains new animations for bows and meshes with the "Weapon Bone Left" bone.

[akortunov]

The main questions here:

1. Should we de-hardcode the table?
2. If yes, should we strictly change the ESM format, of we can just add settings to the openmw.cfg?
3. Can we add an ability to define custom weapon types?

[akortunov]

OK, I allow to override data via openmw.cfg now. An example for left-handed bow:

weapon-type=9;Bow;2b;bowandarrow;Item Weapon Bow;Weapon Bone Left;Bip01 MarksmanBow;23;1;12;1

No editor support yet, but in theory it is possible to create new weapon records via Enchanted Editor since it just uses an integer field for weapon types.

[akortunov]

Added basic weapon types support for the editor.

[akortunov]

All right, time for review and testing, especially for new weapon types.

As about code, I do not like much the weapon types enum with negative values, also a configuration in the openmw.cfg is not very user-friendly. Any ideas how to improve them?

[akortunov]

Also if we are going to move these settings to ESM files later, I can try to setup a virtual ESM::Store for weapon types, but it will not work for editor, where we setup UI widgets only once (IIRC, even before we read data from ESM).

[Capostrophic]

Nobody is really sure if overriding weapon types via configs is the right way to dehardcode them. Before any abrupt decisions are acknowledged in the codebase and it doesn't take too much effort not to have this, I'd reconsider having a stopgap solution this intrusive.

[akortunov]

Replaced by #2413.