Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable controller (feature #3980) #2168

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
5 participants
@Capostrophic
Copy link
Collaborator

commented Feb 15, 2019

Feature 3980.

Adds a button into Controls menu which "toggles" the controller support, the respective option. When it's off, all, or at least most of the controller input events are ignored by the input manager so the detected controller is effectively disabled.

The major issue is that I don't have a controller and cannot tell if it works as it should.
Independent testing reports that this works as intended.

Controls section of the in-game settings looks like this at the moment. We're tight on space.

Note that in Morrowind the equivalent button is forced off when a joystick is not detected. However:

  1. I don't think there's an easy-to-use way to have unique functionality for generic MyGUI-based setting checkboxes
  2. While the setting has no effect when there isn't any controller in the system, it might be less confusing for the user when the button state explicitly shows whether controllers are used or not.

screenshot004

@terabyte25

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

https://wiki.openmw.org/index.php?title=GMSTs_(status) should sEnableJoystick be changed to implemented once this PR gets merged?

@Capostrophic

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 15, 2019

Yes, obviously.

@akortunov

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2019

Can we detect if controller is actually available and hide this button (with Controller tab) if it is not available?

@terabyte25

This comment has been minimized.

@Capostrophic

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 16, 2019

Pretty sure it could be possible to just track controllerAdded and controllerRemoved events somehow and relay them to the window manager and settings window which would then hide/show the redundant widgets. But is it even in the scope of this PR?

@akortunov

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2019

But is it even in the scope of this PR?

Morrowind at least does not allow to enable this setting if it can not find controller.

@wareya

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

What if I want to change the setting when my controller isn't plugged in because of some weird driver problem?

@terabyte25

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

@wareya You modify the settings.cfg file.

@wareya

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

:|

@psi29a

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Great, I'll take it.

@psi29a psi29a merged commit 942f7f7 into OpenMW:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Capostrophic Capostrophic deleted the Capostrophic:gamepad branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.