Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate spell effect argument (bug #4927) #2288

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Capostrophic
Copy link
Collaborator

@Capostrophic Capostrophic commented Mar 26, 2019

Bug 4927

Drop invalid arguments for spell effects that don't really need them to avoid triggering an exception upon effect key generation.

@akortunov
Copy link
Collaborator

akortunov commented Mar 29, 2019

I wish we had a way to do it without additional includes.
Can we add this validation when we read effect data from ESM/ESP file (probably with warning) instead?

@Capostrophic Capostrophic changed the title Allow spell effects to have both a skill and an attribute (bug #4927) [WIP] Allow spell effects to have both a skill and an attribute (bug #4927) Mar 31, 2019
@Capostrophic Capostrophic changed the title [WIP] Allow spell effects to have both a skill and an attribute (bug #4927) Validate spell effect argument (bug #4927) Mar 31, 2019
@Capostrophic Capostrophic force-pushed the magiceffect branch 3 times, most recently from 09a94d5 to 5a1e0d3 Compare March 31, 2019 19:23
@psi29a psi29a merged commit ca6f1bd into OpenMW:master Apr 8, 2019
@Capostrophic Capostrophic deleted the magiceffect branch April 8, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants