Some fixes for building on FreeBSD #882
Conversation
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| #include <string> | |||
|
|
|||
| #include <osg/observer_ptr> | |||
There was a problem hiding this comment.
Why do we need to include observer_ptr when it's not being used in this file?
There was a problem hiding this comment.
We don't. This could be moved to apps/openmw/mwworld/projectilemanager.cpp.
Here is the error I get when it is missing from both files:
In file included from ../apps/openmw/mwworld/projectilemanager.cpp:1:
In file included from ../apps/openmw/mwworld/projectilemanager.hpp:4:
In file included from /usr/include/c++/v1/string:439:
In file included from /usr/include/c++/v1/algorithm:627:
/usr/include/c++/v1/utility:253:9: error: implicit instantiation of undefined template 'osg::observer_ptr<osg::Camera>'
_T1 first;
^
/usr/include/c++/v1/map:629:16: note: in instantiation of template class 'std::__1::pair<const osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > >' requested here
value_type __cc;
^
/usr/include/c++/v1/__tree:1440:14: note: in instantiation of template class 'std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > >' requested here
if (__nd != nullptr)
^
/usr/include/c++/v1/__tree:1433:5: note: in instantiation of member function 'std::__1::__tree<std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > >, std::__1::__map_value_compare<osg::observer_ptr<osg::Camera>, std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > >, std::__1::less<osg::observer_ptr<osg::Camera> >, true>, std::__1::allocator<std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > > > >::destroy' requested here
destroy(__root());
^
/usr/include/c++/v1/__tree:1119:78: note: in instantiation of member function 'std::__1::__tree<std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > >, std::__1::__map_value_compare<osg::observer_ptr<osg::Camera>, std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > >, std::__1::less<osg::observer_ptr<osg::Camera> >, true>, std::__1::allocator<std::__1::__value_type<osg::observer_ptr<osg::Camera>, std::__1::vector<SceneUtil::LightManager::LightSourceViewBound, std::__1::allocator<SceneUtil::LightManager::LightSourceViewBound> > > > >::~__tree' requested here
template <class, class, class, class> friend class _LIBCPP_TYPE_VIS_ONLY map;
^
/usr/local/include/osg/ref_ptr:21:28: note: template is declared here
template<typename T> class observer_ptr;
^
There was a problem hiding this comment.
I also wondered about why you needed to remove const from a few places.
There was a problem hiding this comment.
If I don't I get errors like:
In file included from ../apps/essimporter/importer.cpp:32:
../apps/essimporter/converter.hpp:128:79: error: no viable overloaded '='
mContext->mPlayer.mObject.mCreatureStats.mSpells.mSpells[*it] = empty;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~
/usr/include/c++/v1/map:889:10: note: candidate function not viable: no known conversion from 'map<int, [...], less<int>, [...]>' to 'const map<const int, [...], less<const int>, [...]>' for 1st argument
map& operator=(const map& __m)
^
There was a problem hiding this comment.
What version of GCC or Clang are you using?
I'm able to use both without a problem with Debian userland.
There was a problem hiding this comment.
FreeBSD 10.2 comes with Clang 3.4.1 and LLVM's libc++.
There was a problem hiding this comment.
I'm using clang version 3.6.2-1, but I don't know if that will make a difference.
There was a problem hiding this comment.
In OSX, I'm using clang 3.2 without a problem. :s
I'm guessing this has something to do with FreeBSD's implementation of libstdc++.
There was a problem hiding this comment.
My guess is that the culprit here is indeed FreeBSD's libc++ rather than Clang. When I created the port I tried playing around with different Clang and GCC versions but that lead to a lot of other pain (not related to OpenMW code).
Replacing const int with int was the most straightforward non-hacky solution to those compiler errors I could find.
There was a problem hiding this comment.
/usr/include/c++/v1/utility:253:9: error: implicit instantiation of undefined template 'osg::observer_ptrosg::Camera'
osg::observer_ptr<osg::Camera> is used in components/sceneutil/lightmanager.hpp, so the include should be added there.
Hi,
I'm the maintainer of the OpenMW FreeBSD port. There are some patches that need to be applied to build OpenMW on FreeBSD and I'd like to reduce the diff a little to make future updates of the port easier.
Thanks!