[PHP 8.1] Fix passing null to non-nullable internal function params

[elidrissidev]

Description (*)

This PR fixes lots of "Passing null to non-nullable internal function parameters" deprecation notices introduced in PHP 8.1, which I came across when navigating or performing different actions on the frontend and admin.

The commits are grouped by function for easier review, and the fixes favor casting when appropriate, and PHPdocs to determine where to do the change. For example: Mage_Core_Helper_Data::escapeHtml PHPdoc says it accepts a non-nullable string, so instead of casting the parameter to a string inside the method, I cast the arguments in the usages instead.

Deprecation errors in lib/Zend were skipped in the hope we'll switch to zf1-future soon (?).

Related Pull Requests

• Some changes for compatibility with PHP 8.1 #1812

Manual testing scenarios (*)

1. Make sure the error_reporting directive in your php.ini includes deprecation errors, then comment out the lines below:
   

   magento-lts/app/code/core/Mage/Core/functions.php

   Lines 125 to 128 in 97e0b70

   	// Suppress deprecation warnings on PHP 7.x
   	if ($errno == E_DEPRECATED && version_compare(PHP_VERSION, '7.0.0', '>=')) {
   	return true;
   	}

Questions or comments

Please make sure to review thoroughly before approving.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

LGTM

[luigifab]

Today is a great day!

[fballiano]

@sreichel why hold?

[colinmollenhour]

I inspected each change by reading code and believe that the new code is functionally equivalent to the old code and will fix possible PHP 8.1 errors.

One file appears to have triggered PHPStan so I made a suggestion although the submitted code is just as correct.

[sreichel]

@colinmollenhour stop stop stop :)

This PR was already closed b/c it was split into smaller PRs.

There are some lines I'd like to check .... eg (string)$this->getPath() could be covered by adding getterMethod that returns string,

[colinmollenhour]

@colinmollenhour stop stop stop :)

Oops, my bad.. :) Just trying to get this merged sooner than later since it seems as people run into these issues one by one there will be many more PRs.

[sreichel]

edit: we dont need no PR for every change. We can merge whats left over at the end.

[sreichel]

could be covered by adding getterMethod that returns string,

Can be done later. Think its ready.

[fballiano]

it also seems fine to me

[elidrissidev]

Finally! this PR has went through so much 😆

[fballiano]

I'll just wait for the workflows to finish then merge to both branches, thanks guys

[fballiano]

cherry picked to v20 cause no conflicts