Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved skip-links delegation behavior in RWD mini-cart close button #511

Open
wants to merge 1 commit into
base: 1.9.3.x
from

Conversation

Projects
None yet
4 participants
@rafaelpatro
Copy link

commented Aug 29, 2018

It does not affect the common use for mini-cart.
But when you try to toggle the mini-cart using js... close button won't work because of jquery delegation properties.

Reproduce: Open your cart programatically...

$j('#header-cart').addClass('skip-active');

...and try to close the mini-cart box manually.

@tbaden tbaden added the Review Needed label Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.