Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer billing is erased if the page is refreshed on checkout #588

Open
wants to merge 3 commits into
base: 1.9.3.x
from

Conversation

Projects
None yet
4 participants
@kestraly
Copy link
Contributor

commented Jan 9, 2019

I've changed this for billing.phtml in the persistent template to pull back data into the checkout from the quote for the billing address. billing.phtml within checkout/onepage template, however I'll only include this in the PR if other members feel this is an improved way of retrieving data back to the checkout and retaining customers.

Customer is erased if the page is refreshed. This method would retrie…
…ve the billing address from the quote stored in the database.

kestraly added some commits Jan 9, 2019

@@ -45,14 +45,14 @@
<div class="field">
<label for="billing:company"><?php echo $this->__('Company') ?></label>
<div class="input-box">
<input type="text" id="billing:company" name="billing[company]" value="<?php echo $this->escapeHtml($this->getAddress()->getCompany()) ?>" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Company')) ?>" class="input-text <?php echo $this->helper('customer/address')->getAttributeValidationClass('company') ?>" />
<input type="text" id="billing:company" name="billing[company]" value="<?php echo ($this->getAddress()->getCompany() ? $this->escapeHtml($this->getAddress()->getCompany()) : $this->getQuote()->getBillingAddress()->getCompany()); ?>" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Company')) ?>" class="input-text <?php echo $this->helper('customer/address')->getAttributeValidationClass('company') ?>" />

This comment has been minimized.

Copy link
@kkrieger85

kkrieger85 Jun 2, 2019

Collaborator

Is there a reason on why $this->getQuote()->getBillingAddress()->getCompany() is not echoed with escapeHtml()?

This also concerns all changes in this PR

@kestraly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

Mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.