Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage_Customer - IDE improvements #681

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@sreichel
Copy link
Collaborator

commented May 28, 2019

  • added/fixed missing DOCs
  • changed @return to $this for methods and annotations
  • changed magic methods on Varien_Objects to setData()/getData()
  • flipped @var annotations
Mage_Customer - IDE improvements
- added/fixed missing DOCs
- changed @return to $this for methods and annotations
- changed magic methods on Varien_Objects to setData()/getData()
- flipped @var annotations

@sreichel sreichel added the hold label May 28, 2019

@@ -696,10 +606,9 @@ public function parse()
if ($customer->getDefaultBilling()) {
$model->setDefaultBilling($customer->getDefaultBilling());
} else {
$shippingAddress->save();
$billingAddress->save();

This comment has been minimized.

Copy link
@kkrieger85

kkrieger85 Jun 1, 2019

Collaborator

This is a fundemental code change.

Even if this is right, it should not be in this commit.

This comment has been minimized.

Copy link
@sreichel

sreichel Jun 1, 2019

Author Collaborator

Will be a own PR.

@colinmollenhour

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Just an FYI on the off chance you aren't already aware of this feature, to separate these changes into separate commits one good way is to use git add --interactive and once you get the hang of it, it is pretty fast. It basically presents each "chunk" one at a time so you can stage parts of a file without staging other parts.

@sreichel sreichel closed this Jun 2, 2019

@sreichel sreichel deleted the cleanup/Mage_Customer branch Jun 2, 2019

@sreichel sreichel added invalid and removed hold labels Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.