Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage_Api - DOC block update #693

Open
wants to merge 1 commit into
base: 1.9.4.x
from

Conversation

2 participants
@sreichel
Copy link
Collaborator

commented Jun 2, 2019

Cleaned #677

@@ -31,7 +31,7 @@
* @package Mage_Api
* @author Magento Core Team <core@magentocommerce.com>
*/
class Mage_Api_Model_Server_WSI_Handler extends Mage_Api_Model_Server_Handler_Abstract
class Mage_Api_Model_Server_Wsi_Handler extends Mage_Api_Model_Server_Handler_Abstract

This comment has been minimized.

Copy link
@kkrieger85

kkrieger85 Jun 3, 2019

Collaborator

Code Change: Class renamed

This comment has been minimized.

Copy link
@sreichel

sreichel Jun 3, 2019

Author Collaborator

IMHO a bug that possibly causes autoloader to fail ... please try $test = new Mage_Api_Model_Server_WSI_Handler(); on unchanged code ....

=> Fatal error: Uncaught Error: Class 'Mage_Api_Model_Server_WSI_Handler' not found

This comment has been minimized.

Copy link
@kkrieger85

kkrieger85 Jun 3, 2019

Collaborator

I use openmage-lts 1.9.3.x, installed with composer.
Used magerun dev:console

Both worked:

$test = new Mage_Api_Model_Server_WSI_Handler();
=> Mage_Api_Model_Server_WSI_Handler {#1162}
$test = new Mage_Api_Model_Server_Wsi_Handler();
=> Mage_Api_Model_Server_WSI_Handler {#1114}

 php -v
PHP 7.1.28 (cli) (built: Apr 19 2019 00:35:14) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies
    with Xdebug v2.7.1, Copyright (c) 2002-2019, by Derick Rethans
    with Zend OPcache v7.1.28, Copyright (c) 1999-2018, by Zend Technologies
magerun sys:info

                              
  Magento System Information  
                              

+---------------------+-----------------------------------------------------------------------+
| name                | value                                                                 |
+---------------------+-----------------------------------------------------------------------+
| Version             | 1.9.3.10                                                              |
| Edition             | Community                                                             |

This comment has been minimized.

Copy link
@sreichel

sreichel Jun 3, 2019

Author Collaborator

Strange .... directory is also name in camelcase ...

If i use new Mage_Api_Model_Server_Wsi_Handler(); i get a Mage_Api_Model_Server_WSI_Handler object.

lts 1.9.4.x ...

PHP 7.1.20-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Jul 25 2018 10:06:40) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.1.20-1+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.1, Copyright (c) 2002-2019, by Derick Rethans

Waiting for other reviews :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.