Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage_AdminNotification - DOC block update #695

Open
wants to merge 1 commit into
base: 1.9.4.x
from

Conversation

2 participants
@sreichel
Copy link
Collaborator

commented Jun 2, 2019

Clean #676

  • fixed wrong translation call
Mage_AdminNotification - DOC block update
- fixed wrong translation call
@@ -131,7 +132,7 @@ public function parse(array $data)
public function add($severity, $title, $description, $url = '', $isInternal = true)
{
if (!$this->getSeverities($severity)) {
Mage::throwException($this->__('Wrong message type'));
Mage::throwException(Mage::helper('adminnotification')->__('Wrong message type'));

This comment has been minimized.

Copy link
@kkrieger85

kkrieger85 Jun 3, 2019

Collaborator

Code change: but consistent to other translations in this class

This comment has been minimized.

Copy link
@sreichel

sreichel Jun 3, 2019

Author Collaborator

Its a bug ... __() doesn't exit in model classes.

This comment has been minimized.

Copy link
@kkrieger85

kkrieger85 Jun 3, 2019

Collaborator

Therefore I approved this PR

@kkrieger85
Copy link
Collaborator

left a comment

Approved

@Flyingmana Flyingmana added this to In progress in Project Cleanup Jun 5, 2019

@Flyingmana Flyingmana moved this from In progress to In Review in Project Cleanup Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.