Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage_CurrencySymbol - DOC block update #708

Open
wants to merge 1 commit into
base: 1.9.4.x
from

Conversation

3 participants
@sreichel
Copy link
Collaborator

commented Jun 4, 2019

  • add missing properties
Mage CurrencySymbol - DOC block update
- add missing properties

@sreichel sreichel changed the title Mage CurrencySymbol - DOC block update Mage_CurrencySymbol - DOC block update Jun 4, 2019

@Flyingmana Flyingmana added this to In progress in Project Cleanup Jun 5, 2019

@Flyingmana Flyingmana moved this from In progress to In Review in Project Cleanup Jun 5, 2019

/**
* @var string
*/
private $_blockGroup;

This comment has been minimized.

Copy link
@Sekiphp

Sekiphp Jun 14, 2019

Contributor

I think that _blockGroup, _controller should be protected or deleted. As I see in project this attributes is not used. From this class is not extended any class, so I think, that these variables are pointless.

@Sekiphp
Copy link
Contributor

left a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.