Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Admin Notifications feed URL #796

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@netalico
Copy link
Contributor

commented Aug 5, 2019

This will allow us to control the Feed so that only relevant/important notifications are displayed to merchants.

@kkrieger85

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

@colinmollenhour @Flyingmana Could you please review?

@spinsch

spinsch approved these changes Aug 6, 2019

@Flyingmana Flyingmana merged commit 5e4058a into OpenMage:1.9.4.x Aug 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Flyingmana

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

could please someone check how it works and post a screenshot here?

@spinsch

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

could please someone check how it works and post a screenshot here?

it works when the flag "use_https" is set.
http request returns 301 to redirect https and this will broken the feed update.

Configuration___System___Magento_Admin

@Flyingmana

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

ahh yes, I enforce https on the website (for reasons)
is Magento using http by default?

the ReadMore is a link to the post, or showing post content inside Magento?

but in general, seems to work, thats good :)

@spinsch

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

yes magento use "http" by default.

"Read detail" goto => https://openmage.github.io/Web_Notifications//2019/06/24/OpenMage.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.