Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send (or not) Autograd Tensor #2797

Open
LaRiffle opened this issue Dec 9, 2019 · 4 comments
Open

Send (or not) Autograd Tensor #2797

LaRiffle opened this issue Dec 9, 2019 · 4 comments

Comments

@LaRiffle
Copy link
Collaborator

@LaRiffle LaRiffle commented Dec 9, 2019

Is your feature request related to a problem? Please describe.
Currently, sending/getting Autograd tensors cause an error because grad_fn is added to the args serialize which is not possible.

Alternative solutions
A. Either we want to serialize AutogradTensor and we A.1 remove the grad_fn arg or A.2 add serialization for all the grad_fn components or B. We don't want AutogradTensor to be sent across the wire and we raise an explicit error

Describe the solution you'd like
We need to serialize grad_fn for AutogradTensor. To do so, one needs to understand how grad_fn is built up in PySyft and how the components should be serialized is an easy way (= try avoiding modifying syft/serde too much)

This triggers weird errors like: #2666

@LaRiffle

This comment has been minimized.

Copy link
Collaborator Author

@LaRiffle LaRiffle commented Dec 9, 2019

Related to: #2137

@iamtrask

This comment has been minimized.

Copy link
Member

@iamtrask iamtrask commented Dec 9, 2019

We should allow autograd tensor to be sendable across the wire, but we should serialize the functions using a string version of them (with specific ones whitelisted) instead of serializaing any function at all.

CC: @karlhigley this is related to what you were talking about.

@sukhadj

This comment has been minimized.

Copy link
Member

@sukhadj sukhadj commented Dec 14, 2019

Can I work on this?

@adityaprabhat01

This comment has been minimized.

Copy link

@adityaprabhat01 adityaprabhat01 commented Feb 25, 2020

Is this issue still open?
Can I be assigned to work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.