New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hook method and property -RSTensor #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the overall structure of ReplicatedSharedTensor is as follows.
MPCTensor->ReplicatedSharedTensor->List[Torch Tensors]
So that means RSTensor holds shares of torch tensors and not sharetensors. RSTensor and ShareTensors are two seperate types of sharetensors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have at the moment:
MPCTensor holds ShareTensor holds Torch Tensors
For Falcon it might be
MPCTensor holds RSS Tensor hold Torch Tensor
The init method of RSS Tensor had List[ShareTensor], I assumed as List[ShareTensor] ,I would refactor it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @aanurraj could you have a look?
Description
Modified the hook method and property of ReplicatedSharedTensor. fixes #177
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Added test for hook methods and property.
Checklist