-
Notifications
You must be signed in to change notification settings - Fork 61
Fix init message for FMI #1979
Fix init message for FMI #1979
Conversation
| retValue = -1; | ||
| } | ||
| if (!retValue) | ||
| infoStreamPrint(LOG_STDOUT, 0, "The initialization finished successfully %s homotopy method.", data->simulationInfo->homotopyUsed ? "with" : "without"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't log this to STDOUT; if you do we can't disable it in the logging settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add an option to disable LOG_STDOUT or we can have a new default notification stream that is enabled by default – which is then basically the same as having an option to disable LOG_STDOUT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about these two possibilities. We could have the option -lv=NO_STDOUT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't touch stdout. This belongs to LOG_INIT or a separate category.
5892842 to
f328034
Compare
|
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-11-06_16-44-46. |
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2017-11-06_17-36-18. |
Belonging to [master]: - #1979 - OpenModelica/OpenModelica-testsuite#762
Belonging to [master]: - #1979 - OpenModelica/OpenModelica-testsuite#762
Belonging to [master]: - OpenModelica/OMCompiler#1979 - #762
No description provided.