Skip to content
This repository was archived by the owner on May 18, 2019. It is now read-only.

Conversation

@ptaeuber
Copy link
Contributor

@ptaeuber ptaeuber commented Nov 6, 2017

No description provided.

retValue = -1;
}
if (!retValue)
infoStreamPrint(LOG_STDOUT, 0, "The initialization finished successfully %s homotopy method.", data->simulationInfo->homotopyUsed ? "with" : "without");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't log this to STDOUT; if you do we can't disable it in the logging settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an option to disable LOG_STDOUT or we can have a new default notification stream that is enabled by default – which is then basically the same as having an option to disable LOG_STDOUT.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought about these two possibilities. We could have the option -lv=NO_STDOUT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't touch stdout. This belongs to LOG_INIT or a separate category.

@ptaeuber
Copy link
Contributor Author

ptaeuber commented Nov 6, 2017

@sjoelund @lochel Now the defaultly printed success messages are moved from stdout to a new stream LOG_SUCCESS, which can be deactivated by -lv=-LOG_SUCCESS.

@OpenModelica-Hudson
Copy link
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-11-06_16-44-46.

@OpenModelica-Hudson
Copy link
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2017-11-06_17-36-18.

OpenModelica-Hudson pushed a commit that referenced this pull request Nov 6, 2017
OpenModelica-Hudson pushed a commit to OpenModelica/OpenModelica-testsuite that referenced this pull request Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants