improve OMCSessionPort #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
force-pushed
the
OMCSessionPort
branch
from
f14cf3b to
d42e051
Compare
OMCSessionPort is a limited version as we do not know how OMC is run.
syntron
force-pushed
the
OMCSessionPort
branch
from
7cbdd2c to
dd67406
Compare
Contributor
Author
|
@adeas31 as for the unittest part: why for v5.0.0? This change has no impact on (external) users and, thus, could be included now; here is it even more important as it fixes some possible crashs (use of functionality not available in OMCSessionPort) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on top of PR #386
improve the class OMCSessionPort by catching some things which are NOT working; reason: here, we only have the port but no information how OMC was started