Add assert check for event sub-clocks (#8650)

Author: phannebohm

OMCompiler/SimulationRuntime/c/simulation/solver/synchronous.c

@@ -62,6 +62,11 @@ void initSynchronous(DATA* data, threadData_t *threadData, modelica_real startTi
       assertStreamPrint(threadData, data->simulationInfo->baseClocks[i].subClocks[j].solverMethod != NULL, "Continuous clocked systems aren't supported yet.");
       assertStreamPrint(threadData, floorRat(data->simulationInfo->baseClocks[i].subClocks[j].shift) >= 0, "Shift of sub-clock is negative. Sub-clocks aren't allowed to fire before base-clock.");
     }
+    if (data->simulationInfo->baseClocks[i].isEventClock) { /*event clock*/
+      for(j=0; j<data->simulationInfo->baseClocks[i].nSubClocks; j++) {
+        assertStreamPrint(threadData, data->simulationInfo->baseClocks[i].subClocks[j].factor.den == 1, "Factor of sub-clock of event-clock is not an integer, this is not allowed.");
+      }
+    }
   }
 
   for(i=0; i<data->modelData->nBaseClocks; i++)

testsuite/simulation/modelica/synchronous/EventSubClock.mo

@@ -0,0 +1,10 @@
+within ;
+model EventSubClock "See Modelica 3.5 spec, section 16.5.2 Sub-clock conversion operators"
+  Clock c = Clock(time > 0.5);
+  Clock c1 = superSample(c, 2);
+  Integer n(start=1, fixed=true);
+equation
+  when c1 then
+    n = previous(n) + 1;
+  end when;
+end EventSubClock;

testsuite/simulation/modelica/synchronous/EventSubClock.mos

@@ -0,0 +1,20 @@
+// name: EventSubClock
+// keywords: synchronous clocked equations
+// status: correct
+// cflags: -d=-newInst --std=3.3
+
+loadFile("EventSubClock.mo");getErrorString();
+simulate(EventSubClock);getErrorString();
+// Result:
+// true
+// ""
+// record SimulationResult
+//     resultFile = "",
+//     simulationOptions = "startTime = 0.0, stopTime = 1.0, numberOfIntervals = 500, tolerance = 1e-06, method = 'dassl', fileNamePrefix = 'EventSubClock', options = '', outputFormat = 'mat', variableFilter = '.*', cflags = '', simflags = ''",
+//     messages = "Simulation execution failed for model: EventSubClock
+// assert            | debug   | Factor of sub-clock of event-clock is not an integer, this is not allowed.
+// assert            | info    | simulation terminated by an assertion at initialization
+// "
+// end SimulationResult;
+// ""
+// endResult

testsuite/simulation/modelica/synchronous/Makefile

@@ -6,6 +6,7 @@ Bug3503.mos \
 EventClock.mos \
 EventClock_cpp.mos \
 EventClockAndClassic.mos \
+EventSubClock.mos \
 MutuallyDependentClocks.mos \
 SamplingWithClocks.mos \
 subSample.mos \