Only link to existing files.

- Make runtest.pl only create symlinks to existing files, to avoid
  that files generated by test cases escape their sandboxes.
- Remove the name of the sandbox folder in paths when running tests with
  runtest.pl, since they contain the process id which changes each time.

Author: perost

OMCompiler/Compiler/Util/Testsuite.mo

@@ -78,6 +78,13 @@ algorithm
         newName := if Autoconf.os == "Windows_NT" then System.stringReplace(name, "\\", "/") else name;
         (i,strs) := System.regex(newName, "^(.*/Compiler/)?(.*/testsuite/(libraries-for-testing/.openmodelica/libraries/)?)?(.*/lib/omlibrary/)?(.*/build/)?(.*)$", 7, true, false);
         friendly := listGet(strs,i);
+
+        // Remove the name of any temporary folders used to sandbox a test case,
+        // since they contain the process id which changes each time the test is run.
+        (i,strs) := System.regex(friendly, "^(.*)(/[_[:alnum:]]*\\.mos?_temp[0-9]*)(.*)$", 4, true, false);
+        if i == 4 then
+          friendly := listGet(strs, 2) + listGet(strs, 4);
+        end if;
       then
         friendly;
 

testsuite/partest/runtest.pl

@@ -55,12 +55,22 @@ sub make_link {
   # Depending on how the path is given we need to use different rules for how
   # the symlink should be created.
   for ($file) {
-    if    (/\.\.\/(\w*)\/package.mo/) { symlink("../" . $1, "../" . $1); }
-    elsif (/\.\/(\w*)\/package.mo/)   { symlink("../" . $1, $1); }
-    elsif (/\.\.\/([\w-]*)\//)        { symlink("../" . $1, "../" . $1); }
-    elsif (/^(\w*)\/(.*)/)            { symlink("../" . $1, $1); }
-    elsif (/(.*)/)                    { symlink("../" . $1, $1); }
-    else                              { symlink("../" . $file, $file); }
+    if    (/\.\.\/(\w*)\/package.mo/) { symlink_if_exists("../" . $1, "../" . $1); }
+    elsif (/\.\/(\w*)\/package.mo/)   { symlink_if_exists("../" . $1, $1); }
+    elsif (/\.\.\/([\w-]*)\//)        { symlink_if_exists("../" . $1, "../" . $1); }
+    elsif (/^(\w*)\/(.*)/)            { symlink_if_exists("../" . $1, $1); }
+    elsif (/(.*)/)                    { symlink_if_exists("../" . $1, $1); }
+    else                              { symlink_if_exists("../" . $file, $file); }
+  }
+}
+
+# Creates a symbolic link to a file, but only if the file exists.
+sub symlink_if_exists {
+  my $src = shift;
+  my $dst = shift;
+
+  if (-e $src) {
+    symlink($src, $dst)
   }
 }
 
@@ -146,7 +156,6 @@ sub enter_sandbox {
     if    (/$stop_expr/)               { last; }
     elsif (/setup_command.*\s(.*\.c)/) { make_link($1); }
     elsif (/depends: *([A-Za-z0-9_.-]*)/) { make_link($1); }
-    elsif (/loadFile.*\(\"linearized_model\.mo\"\)/) {}
     elsif (/loadFile.*\(\"(.*)\"\)/)   { make_link($1); }
     elsif (/runScript.*\(\"(.*)\"\)/)  { make_link($1); }
     elsif (/importFMU.*\(\"(.*)\"\)/)  { make_link($1); }