Check that complex types have the same named elements (#10804)

Author: perost

OMCompiler/Compiler/NFFrontEnd/NFTypeCheck.mo

@@ -1816,6 +1816,11 @@ algorithm
           matchKind := MatchKind.NOT_COMPATIBLE;
         else
           for i in 1:arrayLength(comps1) loop
+            if InstNode.name(comps1[i]) <> InstNode.name(comps2[i]) then
+              matchKind := MatchKind.NOT_COMPATIBLE;
+              break;
+            end if;
+
             comp2 := InstNode.component(comps2[i]);
 
             if Component.isTyped(comp2) then
@@ -1871,6 +1876,11 @@ algorithm
           matchKind := MatchKind.NOT_COMPATIBLE;
         else
           for i in 1:arrayLength(comps1) loop
+            if InstNode.name(comps1[i]) <> InstNode.name(comps2[i]) then
+              matchKind := MatchKind.NOT_COMPATIBLE;
+              break;
+            end if;
+
             comp2 := InstNode.component(comps2[i]);
 
             if Component.isTyped(comp2) then

testsuite/flattening/modelica/scodeinst/FuncWrongType2.mo

@@ -0,0 +1,38 @@
+// name: FuncWrongType2
+// keywords:
+// status: incorrect
+// cflags: -d=newInst
+//
+// Checks that type checking works for functions.
+//
+
+record A
+  Real a1;
+end A;
+
+record B
+  Real b1;
+end B;
+
+function F
+  input A in_a;
+end F;
+
+model FuncWrongType2
+  B b(b1 = time);
+algorithm
+  F(b);
+end FuncWrongType2;
+
+// Result:
+// Error processing file: FuncWrongType2.mo
+// [flattening/modelica/scodeinst/FuncWrongType2.mo:24:3-24:7:writable] Error: Type mismatch for positional argument 1 in F(in_a=b). The argument has type:
+//   B
+// expected type:
+//   A
+//
+// # Error encountered! Exiting...
+// # Please check the error message and the flags.
+//
+// Execution failed!
+// endResult

testsuite/flattening/modelica/scodeinst/Makefile

@@ -639,6 +639,7 @@ FuncVectorizationCastConflict1.mo \
 FuncVectorizationMap1.mo \
 FuncWildcard.mo \
 FuncWrongType.mo \
+FuncWrongType2.mo \
 FunctionalArg1.mo \
 FunctionalArg2.mo \
 FunctionalArg3.mo \