Skip to content

Commit cc2b046

Browse files
committed
- OMEdit: Check getErrorString() after loadModel()
git-svn-id: https://openmodelica.org/svn/OpenModelica/trunk@10124 f25d12d1-65f4-0310-ae8a-bbce733d8d8e
1 parent 4c152c8 commit cc2b046

File tree

3 files changed

+10
-15
lines changed

3 files changed

+10
-15
lines changed

OMEdit/OMEditGUI/LibraryWidget.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -621,12 +621,8 @@ void LibraryTree::createActions()
621621
void LibraryTree::addModelicaStandardLibrary()
622622
{
623623
// load Modelica Standard Library.
624-
QStringList failed;
625-
mpParentLibraryWidget->mpParentMainWindow->mpOMCProxy->loadStandardLibrary(failed);
624+
mpParentLibraryWidget->mpParentMainWindow->mpOMCProxy->loadStandardLibrary();
626625

627-
foreach (QString lib, failed) {
628-
mpParentLibraryWidget->mpParentMainWindow->mpMessageWidget->printGUIErrorMessage(QString("Failed to load library " + lib));
629-
}
630626
QStringList libs = mpParentLibraryWidget->mpParentMainWindow->mpOMCProxy->getClassNames("");
631627
libs.sort();
632628
foreach (QString lib, libs) {

OMEdit/OMEditGUI/OMCProxy.cpp

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -449,13 +449,7 @@ void OMCProxy::restartApplication()
449449
QString OMCProxy::getErrorString()
450450
{
451451
sendCommand("getErrorString()");
452-
if (getResult().size() > 3)
453-
return getResult();
454-
else
455-
{
456-
setResult(tr(""));
457-
return getResult();
458-
}
452+
return StringHandler::unparse(getResult());
459453
}
460454

461455
QString OMCProxy::getVersion()
@@ -511,7 +505,7 @@ QString OMCProxy::getEnvironmentVar(QString name)
511505
}
512506

513507
//! Loads the OpenModelica Standard Library.
514-
void OMCProxy::loadStandardLibrary(QStringList &failed)
508+
void OMCProxy::loadStandardLibrary()
515509
{
516510
QSettings settings(QSettings::IniFormat, QSettings::UserScope, "openmodelica", "omedit");
517511

@@ -532,7 +526,12 @@ void OMCProxy::loadStandardLibrary(QStringList &failed)
532526
QString command = "loadModel(" + lib + ",{\"" + version + "\"})";
533527
sendCommand(command);
534528
if (!StringHandler::unparseBool(getResult())) {
535-
failed.prepend(lib);
529+
mpParentMainWindow->mpMessageWidget->printGUIErrorMessage(getErrorString());
530+
} else {
531+
QString str = getErrorString();
532+
if (str.size()) {
533+
mpParentMainWindow->mpMessageWidget->printGUIWarningMessage(str);
534+
}
536535
}
537536
}
538537

OMEdit/OMEditGUI/OMCProxy.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class OMCProxy : public QObject
9696
QString getAnnotationVersion();
9797
bool setEnvironmentVar(QString name, QString value);
9898
QString getEnvironmentVar(QString name);
99-
void loadStandardLibrary(QStringList &failed);
99+
void loadStandardLibrary();
100100
QStringList getClassNames(QString className = QString());
101101
QStringList getClassNamesRecursive(QString className);
102102
QStringList getClassInformation(QString modelName);

0 commit comments

Comments
 (0)