Skip to content

Commit d6bf3ff

Browse files
arun3688adeas31
authored andcommitted
minor name fixes for advanced search
1 parent 86a7dae commit d6bf3ff

File tree

2 files changed

+37
-36
lines changed

2 files changed

+37
-36
lines changed

OMEdit/OMEditGUI/Search/SearchWidget.cpp

Lines changed: 32 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -169,10 +169,10 @@ void SearchWidget::updateComboBoxSearchStrings(QComboBox *pComboBox)
169169
*/
170170
void SearchWidget::deleteSearchResultWidgets()
171171
{
172-
for (int i = 0; i < pSearchWidgetResultobjects.size(); ++i) {
173-
delete pSearchWidgetResultobjects[i];
172+
for (int i = 0; i < mSearchResultWidgetobjects.size(); ++i) {
173+
delete mSearchResultWidgetobjects[i];
174174
}
175-
pSearchWidgetResultobjects.clear();
175+
mSearchResultWidgetobjects.clear();
176176
}
177177

178178
/*!
@@ -188,21 +188,21 @@ void SearchWidget::searchInFiles()
188188
updateComboBoxSearchStrings(mpSearchStringComboBox);
189189
updateComboBoxSearchStrings(mpSearchFilePatternComboBox);
190190
/* create a new instance of searchresult widget and search widget for every new search */
191-
mpSearchWidgetResult = new SearchWidgetResult;
192-
pSearchWidgetResultobjects.append(mpSearchWidgetResult);
191+
mpSearchResultWidget = new SearchResultWidget;
192+
mSearchResultWidgetobjects.append(mpSearchResultWidget);
193193
mpSearch = new Search(this);
194-
connect(mpSearch, SIGNAL(setTreeWidgetItems(SearchFileDetails)), mpSearchWidgetResult, SLOT(updateTreeWidgetItems(SearchFileDetails)));
195-
connect(mpSearch, SIGNAL(setProgressBarRange(int)), mpSearchWidgetResult, SLOT(updateProgressBarRange(int)));
196-
connect(mpSearch, SIGNAL(setProgressBarValue(int,int)), mpSearchWidgetResult, SLOT(updateProgressBarValue(int,int)));
197-
connect(mpSearch, SIGNAL(setFoundFilesLabel(int)), mpSearchWidgetResult, SLOT(updateFoundFilesLabel(int)));
198-
connect(mpSearch, SIGNAL(setProgressBarCancelValue(int,int)), mpSearchWidgetResult, SLOT(updateProgressBarCancelValue(int,int)));
199-
connect(mpSearchWidgetResult, SIGNAL(setCancelSearchResult()), mpSearch, SLOT(updateCancelSearch()));
194+
connect(mpSearch, SIGNAL(setTreeWidgetItems(SearchFileDetails)), mpSearchResultWidget, SLOT(updateTreeWidgetItems(SearchFileDetails)));
195+
connect(mpSearch, SIGNAL(setProgressBarRange(int)), mpSearchResultWidget, SLOT(updateProgressBarRange(int)));
196+
connect(mpSearch, SIGNAL(setProgressBarValue(int,int)), mpSearchResultWidget, SLOT(updateProgressBarValue(int,int)));
197+
connect(mpSearch, SIGNAL(setFoundFilesLabel(int)), mpSearchResultWidget, SLOT(updateFoundFilesLabel(int)));
198+
connect(mpSearch, SIGNAL(setProgressBarCancelValue(int,int)), mpSearchResultWidget, SLOT(updateProgressBarCancelValue(int,int)));
199+
connect(mpSearchResultWidget, SIGNAL(setCancelSearchResult()), mpSearch, SLOT(updateCancelSearch()));
200200
/*emit the signals to stop any ongoing search operation when mainwindow is closed*/
201201
connect(this, SIGNAL(setCancelSearch()), mpSearch, SLOT(updateCancelSearch()));
202202

203-
mpSearchStackedWidget->addWidget(mpSearchWidgetResult);
204-
mpSearchStackedWidget->setCurrentWidget(mpSearchWidgetResult);
205-
QString searchHistoryItem = QString("%1%2%3 %4").arg("Project-").arg(mpSearchScopeComboBox->currentText()).arg(":").arg(mpSearchStringComboBox->currentText());
203+
mpSearchStackedWidget->addWidget(mpSearchResultWidget);
204+
mpSearchStackedWidget->setCurrentWidget(mpSearchResultWidget);
205+
QString searchHistoryItem = QString("%1-%2: %3").arg(tr("Project")).arg(mpSearchScopeComboBox->currentText()).arg(mpSearchStringComboBox->currentText());
206206
mpSearchHistoryComboBox->addItem(searchHistoryItem);
207207
mpSearchHistoryComboBox->setCurrentIndex(mpSearchHistoryComboBox->findText(searchHistoryItem));
208208
/* start the search in seperate thread using QtConcurrent */
@@ -234,7 +234,7 @@ void SearchWidget::switchSearchPage(int index)
234234
void SearchWidget::expandAll()
235235
{
236236
if(mpSearchStackedWidget->currentIndex()!=0){
237-
pSearchWidgetResultobjects[mpSearchStackedWidget->currentIndex()-1]->getSearchTreeWidget()->expandAll();
237+
mSearchResultWidgetobjects[mpSearchStackedWidget->currentIndex()-1]->getSearchTreeWidget()->expandAll();
238238
}
239239
}
240240

@@ -245,7 +245,7 @@ void SearchWidget::expandAll()
245245
void SearchWidget::collapseAll()
246246
{
247247
if(mpSearchStackedWidget->currentIndex()!=0){
248-
pSearchWidgetResultobjects[mpSearchStackedWidget->currentIndex()-1]->getSearchTreeWidget()->collapseAll();
248+
mSearchResultWidgetobjects[mpSearchStackedWidget->currentIndex()-1]->getSearchTreeWidget()->collapseAll();
249249
}
250250
}
251251

@@ -278,13 +278,13 @@ void SearchWidget::enableDisableExpandCollapseAction(int index)
278278
}
279279

280280
/*!
281-
* \brief SearchWidgetResult::SearchWidgetResult
281+
* \brief SearchResultWidget::SearchResultWidget
282282
* \class which handles the results for the search operation
283283
* \create a instance of this class and add to stack widget for each search operation
284284
* \param pParent
285285
*/
286286

287-
SearchWidgetResult::SearchWidgetResult(QWidget *pParent)
287+
SearchResultWidget::SearchResultWidget(QWidget *pParent)
288288
: QWidget(pParent)
289289
{
290290
mpProgressLabel = new Label;
@@ -323,11 +323,11 @@ SearchWidgetResult::SearchWidgetResult(QWidget *pParent)
323323
}
324324

325325
/*!
326-
* \brief SearchWidgetResult::findAndOpenTreeWidgetItems
326+
* \brief SearchResultWidget::findAndOpenTreeWidgetItems
327327
* SLOT function to open the search results from the
328328
* tree items in the editor and to the corresponding line number
329329
*/
330-
void SearchWidgetResult::findAndOpenTreeWidgetItems(QTreeWidgetItem *item, int column)
330+
void SearchResultWidget::findAndOpenTreeWidgetItems(QTreeWidgetItem *item, int column)
331331
{
332332
QVariant value = item->data(column, Qt::UserRole);
333333
if (!value.isNull()) {
@@ -346,7 +346,7 @@ void SearchWidgetResult::findAndOpenTreeWidgetItems(QTreeWidgetItem *item, int c
346346
* each tree item with filename and subchild with line numbers and
347347
* found lines
348348
*/
349-
void SearchWidgetResult::updateTreeWidgetItems(SearchFileDetails fileDetails)
349+
void SearchResultWidget::updateTreeWidgetItems(SearchFileDetails fileDetails)
350350
{
351351
QTreeWidgetItem *pTreeWidgetItem = new QTreeWidgetItem();
352352
pTreeWidgetItem->setText(0, fileDetails.mFileName);
@@ -366,51 +366,51 @@ void SearchWidgetResult::updateTreeWidgetItems(SearchFileDetails fileDetails)
366366
}
367367

368368
/*!
369-
* \brief SearchWidgetResult::updateProgressBarRange
369+
* \brief SearchResultWidget::updateProgressBarRange
370370
* SLOT to update the progressbarrange in the GUI
371371
*/
372-
void SearchWidgetResult::updateProgressBarRange(int size)
372+
void SearchResultWidget::updateProgressBarRange(int size)
373373
{
374374
mpProgressBar->setRange(0,size);
375375
}
376376

377377
/*!
378-
* \brief SearchWidgetResult::updateProgressBarValue
378+
* \brief SearchResultWidget::updateProgressBarValue
379379
* SLOT to update the progressbarvalue in the GUI
380380
* in incremental order according to file search
381381
*/
382-
void SearchWidgetResult::updateProgressBarValue(int value, int size)
382+
void SearchResultWidget::updateProgressBarValue(int value, int size)
383383
{
384384
mpProgressBar->setValue(value+1);
385385
mpProgressLabel->setText(tr("Searching <b>%1</b> of <b>%2</b> files. Please wait for a while").arg(QString::number(value+1)).arg(QString::number(size)));
386386
}
387387

388388
/*!
389-
* \brief SearchWidgetResult::updateProgressBarCancelValue
389+
* \brief SearchResultWidget::updateProgressBarCancelValue
390390
* SLOT to update the progressbarcancelvalue in the GUI
391391
* when the user cancels the search and update the results
392392
*/
393-
void SearchWidgetResult::updateProgressBarCancelValue(int value, int size)
393+
void SearchResultWidget::updateProgressBarCancelValue(int value, int size)
394394
{
395395
mpProgressBar->setValue(size);
396396
mpProgressLabel->setText(tr("Searched <b>%1</b> of <b>%2</b> files. Search Cancelled").arg(QString::number(value+1)).arg(QString::number(size)));
397397
}
398398

399399
/*!
400-
* \brief SearchWidgetResult::updateFoundFilesLabel
400+
* \brief SearchResultWidget::updateFoundFilesLabel
401401
* SLOT to update the number of foundfiles from
402402
* the search results
403403
*/
404-
void SearchWidgetResult::updateFoundFilesLabel(int value)
404+
void SearchResultWidget::updateFoundFilesLabel(int value)
405405
{
406406
mpProgressLabelFoundFiles->setText(tr("<b>%1</b> FOUND").arg(value));
407407
}
408408

409409
/*!
410-
* \brief SearchWidgetResult::cancelSearch
410+
* \brief SearchResultWidget::cancelSearch
411411
* SLOT to cance the current ongoing search operation
412412
*/
413-
void SearchWidgetResult::cancelSearch()
413+
void SearchResultWidget::cancelSearch()
414414
{
415415
emit setCancelSearchResult();
416416
}
@@ -467,6 +467,7 @@ void Search::run()
467467
// check for cancel operation
468468
if (mStop) {
469469
emit setProgressBarCancelValue(i,filelist.size());
470+
emit setFoundFilesLabel(count-1);
470471
return;
471472
}
472473
emit setProgressBarValue(i,filelist.size());

OMEdit/OMEditGUI/Search/SearchWidget.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
class Label;
4343
class SearchFileDetails;
4444
class Search;
45-
class SearchWidgetResult;
45+
class SearchResultWidget;
4646
class SearchWidget : public QWidget
4747
{
4848
Q_OBJECT
@@ -55,7 +55,7 @@ class SearchWidget : public QWidget
5555
QStackedWidget *getSearchStackedWidget() {return mpSearchStackedWidget;}
5656
QComboBox * getSearchHistoryCombobox() {return mpSearchHistoryComboBox;}
5757
void updateComboBoxSearchStrings(QComboBox *pComboBox);
58-
QList<SearchWidgetResult*> pSearchWidgetResultobjects;
58+
QList<SearchResultWidget*> mSearchResultWidgetobjects;
5959
void deleteSearchResultWidgets();
6060
signals:
6161
void setCancelSearch();
@@ -77,15 +77,15 @@ public slots:
7777
QAction * mpClearAction;
7878
QAction * mpExpandAction;
7979
QAction * mpCollapseAction;
80-
SearchWidgetResult * mpSearchWidgetResult;
80+
SearchResultWidget * mpSearchResultWidget;
8181
Search *mpSearch;
8282
};
8383

84-
class SearchWidgetResult : public QWidget
84+
class SearchResultWidget : public QWidget
8585
{
8686
Q_OBJECT
8787
public:
88-
SearchWidgetResult(QWidget *pParent = 0);
88+
SearchResultWidget(QWidget *pParent = 0);
8989
QProgressBar *getProgressBar() {return mpProgressBar;}
9090
QTreeWidget *getSearchTreeWidget() {return mpSearchTreeWidget;}
9191
signals:

0 commit comments

Comments
 (0)