Improve record constructor creation. (#717)

- Make sure we do not remove bindings from derived record
     declarations. This happens only for the old FrontEnd right now.

   - Improve processing a bit. Instead of checking twice in the list
     of already visited records, create the unique name for the constructor
     and then check only once.

Author: mahge

OMCompiler/Compiler/FrontEnd/Inst.mo

@@ -1022,6 +1022,7 @@ function varIsModifiedInDerivedMod
   output Boolean b;
 algorithm
   b := match inSubmod
+    case SCode.NAMEMOD(mod=SCode.REDECL()) then false;
     case SCode.NAMEMOD() then stringEqual(inSubmod.ident, inName);
   end match;
 end varIsModifiedInDerivedMod;
@@ -3786,7 +3787,7 @@ algorithm
       DAE.Binding bind;
       DAE.Prefix pref;
 
-	    case (bind as DAE.EQBOUND(), pref as DAE.PREFIX(compPre=DAE.PRE())) algorithm
+      case (bind as DAE.EQBOUND(), pref as DAE.PREFIX(compPre=DAE.PRE())) algorithm
         bind.exp := PrefixUtil.removeCompPrefixFromExps(bind.exp, pref.compPre);
       then
         bind;

OMCompiler/Compiler/SimCode/SimCodeFunctionUtil.mo

@@ -1608,38 +1608,32 @@ algorithm
       list<SimCodeFunction.Variable> vars;
       Integer varnum;
       SimCodeFunction.RecordDeclaration recDecl;
+      Boolean is_default;
 
     case (DAE.T_COMPLEX(complexClassType = ClassInf.RECORD(path), varLst = varlst), accRecDecls, rt)
       algorithm
         name := AbsynUtil.pathStringUnquoteReplaceDot(path, "_");
         rt_1 := rt;
 
-        if not listMember(name, rt_1) then
-          rt_1 := name :: rt_1;
-          (accRecDecls, rt_1) := elaborateNestedRecordDeclarations(varlst, accRecDecls, rt_1);
+        (sname, is_default) := checkBindingsandGetConstructorName(name, varlst);
+        // is_default := stringEqual(sname,name);
 
-          varlst := List.map(varlst, simCodeVarRemoveBindFromOutside);
-          vars := List.map(varlst, typesVar);
-          // vars := List.map(vars, simCodeVarRemoveBindFromOutside);
-          recDecl := SimCodeFunction.RECORD_DECL_FULL(name, NONE(), path, vars);
-          accRecDecls := List.appendElt(recDecl, accRecDecls);
-        end if;
+        if not listMember(sname, rt_1) then
+          rt_1 := sname :: rt_1;
+
+          if is_default then
+            (accRecDecls, rt_1) := elaborateNestedRecordDeclarations(varlst, accRecDecls, rt_1);
 
-        sname := name;
-        varnum := 1;
-        for var in varlst loop
-          if var.bind_from_outside then
-            sname := sname + "_" + intString(varnum);
+            vars := List.map(varlst, typesVar);
+            recDecl := SimCodeFunction.RECORD_DECL_FULL(sname, NONE(), path, vars);
+          else
+            vars := List.map(varlst, typesVar);
+            recDecl := SimCodeFunction.RECORD_DECL_ADD_CONSTRCTOR(sname, name, vars);
           end if;
-          varnum := intAdd(varnum,1);
-        end for;
 
-        if not listMember(sname, rt_1) then
-          rt_1 := sname :: rt_1;
-          vars := List.map(varlst, typesVar);
-          recDecl := SimCodeFunction.RECORD_DECL_ADD_CONSTRCTOR(sname, name, vars);
           accRecDecls := List.appendElt(recDecl, accRecDecls);
         end if;
+
       then (accRecDecls, rt_1);
 
     case (DAE.T_COMPLEX(complexClassType = ClassInf.RECORD(_)), accRecDecls, rt)
@@ -1715,18 +1709,38 @@ algorithm
   end match;
 end typesVar;
 
-protected function simCodeVarRemoveBindFromOutside
-  input output DAE.Var var;
+protected function checkBindingsandGetConstructorName
+  input String rec_name;
+  input list<DAE.Var> vars;
+  output String ctor_name;
+  output Boolean is_default;
+protected
+  Integer varnum;
 algorithm
-  _ := match (var)
-    case DAE.TYPES_VAR(binding = DAE.EQBOUND(source=DAE.BINDING_FROM_DERIVED_RECORD_DECL()))
-      then ();
-    case DAE.TYPES_VAR()
-      algorithm
-        var.bind_from_outside := false;
-      then ();
+  is_default := true;
+
+  ctor_name := rec_name;
+  varnum := 1;
+
+  for var in vars loop
+    if var.bind_from_outside and not isBindingFromDerivedRecordDeclaration(var.binding) then
+      is_default := false;
+      ctor_name := ctor_name + "_" + intString(varnum);
+    end if;
+
+    varnum := intAdd(varnum,1);
+  end for;
+end checkBindingsandGetConstructorName;
+
+protected function isBindingFromDerivedRecordDeclaration
+  input DAE.Binding bind;
+  output Boolean b;
+algorithm
+  b := match bind
+    case DAE.EQBOUND(source=DAE.BINDING_FROM_DERIVED_RECORD_DECL())  then true;
+    else false;
   end match;
-end simCodeVarRemoveBindFromOutside;
+end isBindingFromDerivedRecordDeclaration;
 
 protected function checkSourceAndGetBindingExp
   input DAE.Binding inBinding;