Skip to content

Commit e4d06b9

Browse files
committed
ticket:4078
Select the frame with single click or with mouse up & down.
1 parent b906ae8 commit e4d06b9

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

OMEdit/OMEditGUI/Debugger/StackFrames/StackFramesWidget.cpp

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ StackFramesTreeWidget::StackFramesTreeWidget(StackFramesWidget *pStackFramesWidg
164164
setContextMenuPolicy(Qt::CustomContextMenu);
165165
createActions();
166166
connect(mpStackFramesWidget->getMainWindow()->getGDBAdapter(), SIGNAL(stackListFrames(GDBMIValue*)), SLOT(createStackFrames(GDBMIValue*)));
167-
connect(this, SIGNAL(itemDoubleClicked(QTreeWidgetItem*,int)), mpStackFramesWidget, SLOT(stackItemDoubleClicked(QTreeWidgetItem*)));
167+
connect(this, SIGNAL(currentItemChanged(QTreeWidgetItem*,QTreeWidgetItem*)), mpStackFramesWidget, SLOT(stackCurrentItemChanged(QTreeWidgetItem*)));
168168
connect(this, SIGNAL(customContextMenuRequested(QPoint)), this, SLOT(showContextMenu(QPoint)));
169169
}
170170

@@ -209,7 +209,6 @@ void StackFramesTreeWidget::setCurrentStackFrame(QTreeWidgetItem *pQTreeWidgetIt
209209
}
210210
/* set the current item and add icon to it */
211211
mpStackFramesWidget->setSelectedFrame(pStackFrameItem->getLevel().toInt());
212-
setCurrentItem(pStackFrameItem);
213212
pStackFrameItem->setIcon(0, QIcon(":/Resources/icons/next.svg"));
214213
}
215214
}
@@ -264,7 +263,7 @@ void StackFramesTreeWidget::createStackFrames(GDBMIValue *pGDBMIValue)
264263
/* if we get some frames then make the first enabled one selected and fetch the variables for it. */
265264
for (int i = 0 ; i < topLevelItemCount() ; i++) {
266265
if (!topLevelItem(i)->isDisabled()) {
267-
mpStackFramesWidget->stackItemDoubleClicked(topLevelItem(i));
266+
mpStackFramesWidget->stackCurrentItemChanged(topLevelItem(i));
268267
return;
269268
}
270269
}
@@ -628,15 +627,15 @@ void StackFramesWidget::fillThreadComboBox(GDBMIValue *pThreadsGDBMIValue, QStri
628627
}
629628

630629
/*!
631-
* \brief StackFramesWidget::stackItemDoubleClicked
632-
* Slot activated when itemDoubleClicked signal of StackFramesTreeWidget is raised.
630+
* \brief StackFramesWidget::stackCurrentItemChanged
631+
* Slot activated when currentItemChanged signal of StackFramesTreeWidget is raised.
633632
* Sends the -stack-list-variables command.
634633
* \param pQTreeWidgetItem
635634
* \return
636635
*/
637-
void StackFramesWidget::stackItemDoubleClicked(QTreeWidgetItem *pQTreeWidgetItem)
636+
void StackFramesWidget::stackCurrentItemChanged(QTreeWidgetItem *pTreeWidgetItem)
638637
{
639-
StackFrameItem *pStackFrameItem = dynamic_cast<StackFrameItem*>(pQTreeWidgetItem);
638+
StackFrameItem *pStackFrameItem = dynamic_cast<StackFrameItem*>(pTreeWidgetItem);
640639
if (pStackFrameItem && !pStackFrameItem->isDisabled()) {
641640
mpStackFramesTreeWidget->setCurrentStackFrame(pStackFrameItem);
642641
QByteArray cmd = CommandFactory::stackListVariables(getSelectedThread(), getSelectedFrame(), "--simple-values");

OMEdit/OMEditGUI/Debugger/StackFrames/StackFramesWidget.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public slots:
127127
void handleInferiorResumed();
128128
void threadChanged(int threadIndex);
129129
void fillThreadComboBox(GDBMIValue *pThreadsGDBMIValue, QString currentThreadId);
130-
void stackItemDoubleClicked(QTreeWidgetItem *pQTreeWidgetItem);
130+
void stackCurrentItemChanged(QTreeWidgetItem *pTreeWidgetItem);
131131
};
132132

133133
#endif // STACKFRAMESWIDGET_H

0 commit comments

Comments
 (0)