From f51fd255d183e685789a138b8db53de71bcf9f23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Per=20=C3=96stlund?= <per.ostlund@liu.se>
Date: Thu, 29 Jun 2023 17:11:05 +0200
Subject: [PATCH] Don't ignore unknown equations/statements in ConvertDAE
 (#10905)

- Fail on unknown equations/statements in ConvertDAE, they indicate that
  something has gone wrong in earlier phases and shouldn't just be
  silently ignored.
---
 OMCompiler/Compiler/NFFrontEnd/NFConvertDAE.mo | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/OMCompiler/Compiler/NFFrontEnd/NFConvertDAE.mo b/OMCompiler/Compiler/NFFrontEnd/NFConvertDAE.mo
index ddfc4974db6..f83effdc0ba 100644
--- a/OMCompiler/Compiler/NFFrontEnd/NFConvertDAE.mo
+++ b/OMCompiler/Compiler/NFFrontEnd/NFConvertDAE.mo
@@ -633,7 +633,11 @@ algorithm
     case Equation.NORETCALL()
       then DAE.Element.NORETCALL(Expression.toDAE(eq.exp), eq.source) :: elements;
 
-    else elements;
+    else
+      algorithm
+        Error.assertion(false, getInstanceName() + " got unknown equation " + Equation.toString(eq), sourceInfo());
+      then
+        fail();
   end match;
 end convertEquation;
 
@@ -793,7 +797,11 @@ algorithm
     case Equation.NORETCALL()
       then DAE.Element.INITIAL_NORETCALL(Expression.toDAE(eq.exp), eq.source) :: elements;
 
-    else elements;
+    else
+      algorithm
+        Error.assertion(false, getInstanceName() + " got unknown equation " + Equation.toString(eq), sourceInfo());
+      then
+        fail();
   end match;
 end convertInitialEquation;
 
@@ -878,6 +886,11 @@ algorithm
     case Statement.FAILURE()
       then DAE.Statement.STMT_FAILURE(convertStatements(stmt.body), stmt.source);
 
+    else
+      algorithm
+        Error.assertion(false, getInstanceName() + " got unknown statement " + Statement.toString(stmt), sourceInfo());
+      then
+        fail();
   end match;
 end convertStatement;