New generic birate ODE solver #9143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 23, 2022 05:08
… the new time step
- Dump the structure of modifiers instead of just dumping them as strings. - Dump modifiers for classes too, including extends clauses. - Make the modifiers optional.
- Fixed wrong residual counting in KINSOL - Added additional logging case - Fixed headers if WITH_SUNDIALS isn't defined Co-authored-by: bernhardbachmann <bernhardbachmann@users.noreply.github.com>
…elica#9170) - Always include Qt's `QOpenGLContext` header before including any OSG headers. - See OpenModelica#9145 and https://bugreports.qt.io/browse/QTBUG-104673 for reasons behind this requirement. - Improves OpenModelica#9145.
- Catch errors when instantiating annotations and add them to the JSON instead of failing. - Add ErrorExt.printCheckpointMessagesStr. Fixes OpenModelica#9167
…ca#9171) - Instead of failing configuration completely when the required boost libraries are not found, simply disable ParModAuto and continue as it is an optional component anyway. - We can add a configuration option for this but seems like it is an overkill to add an option just for this at the moment. - We should probably handle the CPP runtime in a similar manner. Instead of requiring users to add yet another option to their configuration commandline.
…elica#9174) - Make sure CPP runtime libraries can find boost headers even when boost is not installed in system directories. We do this by linking `Boost:boost` (which provides access to the header only libraries, e.g., ublas) with `OMCppConfig` (`omc::simrt::cpp::config`) All CPP-runtime libraries link to `OMCppConfig`. This means all of them will get access to boost headers transitively. - Make sure the `ParModAuto` library can find boost headers even when boost is not installed in system directories. For this one we can link to Boost::graph (Boost::boost would have worked equally fine)
- Change extends to be an object that contain a class instance instead of being a class instance directly, and add modifiers and annotations from the extends clause to it.
- Use `$value` for binding expressions in SCode modifiers to allow mixing it with submodifiers, and change the structure to be more compact.
…a#9185) - do not combine fcall + string as it SOMEHOW fails?! - splitting it into two calls seems to work
- Use DATA* instead of void*. - Resolve warning when compiling C code.
* Update macOS instructions feedback from hkiel. * more updates to macOS section
make dae mode symbolic jacobian available use `--daeMode --generateSymbolicJacobian` as translation flags and `-jacobian=coloredSymbolical` as simflag.
- Remove CREF_EQUALITY and just use EQUALITY instead, since having "naked" crefs complicates expression traversal and the NF doesn't actually need it. - Convert EQUALITY with crefs to DAE.EQUEQUATION for the old backend, and just use EQUALITY directly in the new backend.
AnHeuermann
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
New development of a generic birate ODE solver.
TODOs