Add cow_bell_1 sound #172
Merged
Add cow_bell_1 sound #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wait, don't merge this yet, just realized I forgot the pack.mcmeta at the root folder |
Member
|
Ah okay, I'd completely have missed that too haha. |
Contributor
Author
|
I tried the new pack with a song ingame and it sounded like it was an octave too low. Are the higher |
Member
|
Oh yeah, two octaves. Since Minecraft goes one octave lower and one higher, you have to shift the sound up two octaves so its lowest pitch matches with the highest one of the default sound (if that makes sense). |
Member
|
Looking good! Thanks for the fix. :) |
Bentroen
added a commit
that referenced
this pull request
Aug 31, 2020
Forgot to pull newer commits before converting the project. Oops. (This is just the merged resource pack from PR #172 and additional data files which GameMaker no longer uses. They were present in the master branch from which the PR was created, but not on the development branch. The merge (be7fbea) then added those files to the development branch, but those changes had not been pulled as the project was converted, so the support files were not deleted on the conversion as they weren't there to begin with).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
I'm not sure why the file is smaller now, but it includes the new sound as well as its entry in
sounds.json.