Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-13016: Add docs for non-privilged ports and non-root ping #3490

Merged
merged 1 commit into from Jul 15, 2021

Conversation

indigo423
Copy link
Member

@indigo423 indigo423 commented Jun 15, 2021

All Contributors

  • Have you read and followed our Contribution Guidelines?
  • Have you made an issue in the OpenNMS issue tracker?
    If so, you should:
    1. update the title of this PR to be of the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the JIRA link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
  • Have you made a comment in that issue which points back to this PR?
  • Have you updated the JIRA link at the bottom of this comment to link to your issue?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it avoid changing files in $OPENNMS_HOME/etc/?

Reviewer Hint

I've created a separate section in the Installation procedure covering just the function receiving SNMP Trap/Informs which is enabled by default. I've removed the Syslogd part cause it is a) a separate feature and b) is disabled by default. I think covering it in a documentation section that describes the Syslogd scenario would make more sense to me.

External References

Base automatically changed from jira/NMS-13016 to develop June 25, 2021 18:28
@indigo423 indigo423 force-pushed the jira/NMS-13016-docs branch 3 times, most recently from e7acc0f to e34209c Compare June 28, 2021 12:40
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for doing this. A few minor changes.

@indigo423 indigo423 force-pushed the jira/NMS-13016-docs branch 2 times, most recently from 7a753ff to 311fb26 Compare June 28, 2021 13:51
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor changes.

Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change

@indigo423 indigo423 requested a review from Bonrob2 July 12, 2021 18:55
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
docs/modules/deployment/pages/core/getting-started.adoc Outdated Show resolved Hide resolved
Describe how to use Firewalld and UFW on CentOS / Ubuntu to forward SNMP Traps/Informs from 162/udp to a high non
priviliged port. We have added also a test procedure using the snmptrap command to verify the configuration.

[ci skip]

Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
@indigo423 indigo423 merged commit b90e3f5 into develop Jul 15, 2021
@indigo423 indigo423 deleted the jira/NMS-13016-docs branch July 15, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants