Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-15292: Escaping parameters in graph results page #5740

Merged
merged 3 commits into from
Jan 30, 2023
Merged

NMS-15292: Escaping parameters in graph results page #5740

merged 3 commits into from
Jan 30, 2023

Conversation

christianpape
Copy link
Contributor

RangerRick
RangerRick approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, but you might want to rebase/merge 2020 to be sure it can go green

aramosvizcarra
aramosvizcarra approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@aramosvizcarra aramosvizcarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianpape christianpape merged commit a47e193 into foundation-2020 Jan 30, 2023
@christianpape christianpape deleted the jira/NMS-15292-smoke branch January 30, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramosvizcarra aramosvizcarra aramosvizcarra approved these changes

@RangerRick RangerRick RangerRick approved these changes

@amay94 amay94 Awaiting requested review from amay94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianpape @RangerRick @aramosvizcarra