Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when undoing multi-map-part import #1168

Closed
dl3sdo opened this issue Oct 29, 2018 · 2 comments

Comments

@dl3sdo
Copy link

commented Oct 29, 2018

Steps to reproduce

  1. Open map with 5 parts
  2. Import another map with 3 parts
  3. Press undo button twice -> mapper crashes

Actual behaviour

Tell us what happens

Expected behaviour

Tell us what should happen instead

Configuration

Mapper Version: 0.83 (x64)
Operating System: Win7x64

@dg0yt

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

By the way, the "default part" objects get imported into the "default part" - so identical objects get duplicated.

@dg0yt dg0yt changed the title Crash when undoing map (containing map parts) import Crash when undoing multi-map-part import Oct 30, 2018
@dg0yt dg0yt self-assigned this Oct 30, 2018
@dg0yt dg0yt added this to the v0.8.4 milestone Oct 30, 2018
@dg0yt dg0yt closed this in 19a3dfc Oct 30, 2018
@dl3sdo

This comment has been minimized.

Copy link
Author

commented Oct 30, 2018

Yes, I noticed that new parts are only added if the map part name does not already exist. I think it would be better to always add new map parts and let the user decide whether he wants to merge them into the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.