Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Edit or Pan tool aborts path drawing #1175

Closed
lpechacek opened this issue Nov 12, 2018 · 6 comments

Comments

@lpechacek
Copy link
Member

commented Nov 12, 2018

Steps to reproduce

  1. Select Path drawing tool and start drawing a line
  2. Choose Edit or Pan tool

Actual behaviour

The freshly drawn line is lost.

Expected behaviour

Realizing that I'm not the only user I'm listing multiple options:

  1. Edit and Pan tools are inactive like the other tools
  2. The line gets finished instead of aborted after selecting Edit. Selecting Pan tool keeps it work-in-progress.
  3. Mapper warns about potential loss of data with OK/Cancel dialog

My preference is towards finishing the line (option 2) and I'd be happy to hear both supporting and contradicting opinions on the solution.

Configuration

Mapper Version: 0.8.3
Operating System: All

@lpechacek lpechacek self-assigned this Nov 12, 2018
@dg0yt

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

Understood.

IMO a dialog (3) is a no-go. With regard to Android, finishing the line (2) might not be what you want in touch mode when clicking on the Pan tool?

@ollesmaps

This comment has been minimized.

Copy link

commented Nov 12, 2018

I have an option 4. The line remains "half-finished" and you can continue drawing after panning.
That would greatly enhance the fluency of drawing as mentioned in #988.

@lpechacek

This comment has been minimized.

Copy link
Member Author

commented Nov 12, 2018

With regard to Android, finishing the line (2) might not be what you want in touch mode when clicking on the Pan tool?

Absolutely. Thanks for the reminder. As Olles pointed out there is open issue to allow panning while drawing. I recalled that one yesterday but kept unconscious of it while writing the issue comment. I'll update the above options accordingly.

lpechacek added a commit to lpechacek/mapper that referenced this issue Dec 21, 2018
Until now the object just drawn would be lost upon tool change. Finish drawing
so that the object is retained.

Closes OpenOrienteeringGH-1175
@lpechacek

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

The above pull request implements part one of option two. I'll look into interaction with Pan tool in the corresponding issue.

@dg0yt

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Dekuji moc, Libor. Indeed, I will try to do v0.8.4 soon.

(For v0.9.0, I'm working on getting Qt 5.12 ready, and I'm on good track. Probably in-time for 5.12.1 which fixes some issues for us.)

@lpechacek

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

Gern getan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.